New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878426 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

running cts sometimes leave a system modal window focusable.

Project Member Reported by osh...@chromium.org, Aug 28

Issue description

Normal task window shouldn't be in the system modal container.
If if it does, other windows created by an app should be removed
once app is removed.

So far I've seen only in CTS. Filing the bug in case we see this
in normal situation.
 
Cc: domlasko...@chromium.org
Actually it looks like the input for place holder shell surface for system modal container got somehow enabled even though there is no other windows.

+dom who may have some idea.
Summary: running cts sometimes leave a system modal window focusable. (was: running cts timetimes leave a transparent window in system modal container)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b1c668cf2ddc7418b79a61a7c38a0a3bec86e53

commit 5b1c668cf2ddc7418b79a61a7c38a0a3bec86e53
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 31 21:38:35 2018

Don't allow window frame on shell surfce in system container

Normal task window shouldn't be in the system modal container,
but can happen due to a bug in Android side. (ex. b/111767668)

This is a safe guard not to show the frame even if it happens.

Bug:  878426 
Test: Covered by unittest
Change-Id: Ib6344acf0ff9ec86b1e40238a8c8e60828948cee
Reviewed-on: https://chromium-review.googlesource.com/1194287
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588175}
[modify] https://crrev.com/5b1c668cf2ddc7418b79a61a7c38a0a3bec86e53/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/5b1c668cf2ddc7418b79a61a7c38a0a3bec86e53/components/exo/client_controlled_shell_surface_unittest.cc

Labels: -Pri-3 Merge-Request-70 M-70 Pri-1
Cc: mikinm@chromium.org kejiashao@chromium.org shibasheikh@chromium.org omrilio@chromium.org osh...@chromium.org
Issue 876488 has been merged into this issue.
Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1859300bbf23c3d2f7d5b91aa5307ecd957670c6

commit 1859300bbf23c3d2f7d5b91aa5307ecd957670c6
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Sep 10 14:58:00 2018

Don't allow window frame on shell surfce in system container

Normal task window shouldn't be in the system modal container,
but can happen due to a bug in Android side. (ex. b/111767668)

This is a safe guard not to show the frame even if it happens.

Bug:  878426 
Test: Covered by unittest
Change-Id: Ib6344acf0ff9ec86b1e40238a8c8e60828948cee
Reviewed-on: https://chromium-review.googlesource.com/1194287
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588175}(cherry picked from commit 5b1c668cf2ddc7418b79a61a7c38a0a3bec86e53)
Reviewed-on: https://chromium-review.googlesource.com/1216523
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#215}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1859300bbf23c3d2f7d5b91aa5307ecd957670c6/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/1859300bbf23c3d2f7d5b91aa5307ecd957670c6/components/exo/client_controlled_shell_surface_unittest.cc

Cc: afakhry@chromium.org
 Issue 881672  has been merged into this issue.
Labels: Hotlist-ConOps-CrOS
Labels: M-69 Merge-Request-69
It's probably too late to merge back to 69, but there are reports that the issue that is fixed in the CL is seen on 69. 
Labels: -M-69 -Merge-Request-69
Status: Fixed (was: Assigned)

Sign in to add a comment