New issue
Advanced search Search tips

Issue 878405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 839970



Sign in to add a comment

Enable use of CHROMIUM_image for low latency canvas on CrOs

Project Member Reported by mcasas@chromium.org, Aug 28

Issue description

Enable use of CHROMIUM_image for low latency canvas on CrOs.

Currently behind a flag chrome://flags#enable-canvas-2d-image-chromium.

Enable it by default for low Latency 2d canvas contexts (not for
non-lowLatency ones).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/609bbed36fc8e2cd83e6ffcd4d3b67bd49543a77

commit 609bbed36fc8e2cd83e6ffcd4d3b67bd49543a77
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Aug 31 03:14:15 2018

Canvas 2d: ignore RuntimeEnabledFeatures for LowLatency() cases

ToT looks at RuntimeEnabledFeatures::Canvas2dImageChromiumEnabled()
(enabled by default for Mac, disabled by default elsewhere) to use
ImageCHROMIUM for Canvas 2D contexts or not.  This is fine, but in
the LowLatency it doesn't make sense not use that features, we
always want to use ImageCHROMIUM (if we |want_acceleration| at all).

Hence this CL:
- ignores the RuntimeEnabledFeature if LowLatency (so all platforms
 will use ImageCHROMIUM for LowLatency -- if |want_acceleration|).
- removes the associated code in runtime_features.cc and about_flags.cc,
 essentially undoing my previous crrev.com/c/1056168. (So that Mac
 can still control the use of ImageCHROMIUM for non-low-latency cases).

Bonus cleanup: simplify |enable_web_gl_image_chromium| initialization.

Bug:  878405 
Change-Id: I91c5422fad82b1146af02c193546f924bbe5448b
Reviewed-on: https://chromium-review.googlesource.com/1194473
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587930}
[modify] https://crrev.com/609bbed36fc8e2cd83e6ffcd4d3b67bd49543a77/chrome/browser/about_flags.cc
[modify] https://crrev.com/609bbed36fc8e2cd83e6ffcd4d3b67bd49543a77/content/child/runtime_features.cc
[modify] https://crrev.com/609bbed36fc8e2cd83e6ffcd4d3b67bd49543a77/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc

Status: Fixed (was: Assigned)

Sign in to add a comment