New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878397 link

Starred by 1 user
Status: Fixed
Owner:
simonhatch@chromium.org
Closed: Aug 29
Cc:
benjhayden@chromium.org
dtu@chromium.org
█ eakuefner@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 863861



Sign in to add a comment

Dashboard - Move request handlers to base dashboard directory

Project Member Reported by simonhatch@chromium.org, Aug 28 
In  crbug.com/863861 , pinpoint imports a histogram model which through some chain of events is importing request_handler on the dashboard (likely through layered_cache). It looks like layered_cache defines a request handler to deleted expired data right there in the file, we should move this out into / and layered_cache into /common. Informally, we've defined all handlers at that level and the rest in places like /common so that you don't have to pull in stuff like request_handler (and thus jinja).

Or we could just add jinja to pinpoint's dependancies.

Comment 1 by simonhatch@chromium.org, Aug 28

Blocking: 863861

Comment 2 by simonhatch@chromium.org, Aug 28

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/3a64f6fe714714d88ad2f67cbddd419424a5fe7f

commit 3a64f6fe714714d88ad2f67cbddd419424a5fe7f
Author: Simon <simonhatch@chromium.org>
Date: Tue Aug 28 23:56:43 2018

Dashboard - Split layered_cache handler and functionality.

TBR=eakuefner@chromium.org
Bug:  chromium:878397 
Change-Id: Ibc10bb848f00cf359033575bec2c48d88a26a090
Reviewed-on: https://chromium-review.googlesource.com/1194705
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/update_bug_with_results.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/dispatcher.py
[add] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/layered_cache_delete_expired.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/list_tests.py
[rename] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/common/layered_cache.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/deprecate_tests.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/models/graph_data.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/list_tests_test.py
[rename] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/common/layered_cache_test.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/update_bug_with_results_test.py
[modify] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/add_point_test.py
[add] https://crrev.com/3a64f6fe714714d88ad2f67cbddd419424a5fe7f/dashboard/dashboard/layered_cache_delete_expired_test.py

Comment 4 by simonhatch@chromium.org, Aug 29

Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5473bfed48da4061b0c426f07147793dd2922f8f

commit 5473bfed48da4061b0c426f07147793dd2922f8f
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 29 01:43:58 2018

Roll src/third_party/catapult 85388f16f3fa..3a64f6fe7147 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/85388f16f3fa..3a64f6fe7147


git log 85388f16f3fa..3a64f6fe7147 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 simonhatch@chromium.org Dashboard - Split layered_cache handler and functionality.
2018-08-28 benjhayden@chromium.org Update webapp2 version.


Created with:
  gclient setdep -r src/third_party/catapult@3a64f6fe7147

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:878397 
TBR=sullivan@chromium.org

Change-Id: I68a04c46453d7cb83bafb6962594e666a01936e5
Reviewed-on: https://chromium-review.googlesource.com/1195082
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586988}
[modify] https://crrev.com/5473bfed48da4061b0c426f07147793dd2922f8f/DEPS
►

Sign in to add a comment