New issue
Advanced search Search tips

Issue 878396 link

Starred by 2 users
Status: Fixed
Owner:
fbeaufort@chromium.org
Closed: Sep 10
Cc:
jochen@chromium.org
rdevlin....@chromium.org
beaufort...@gmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PictureInPictureInBackgroundPage flaky on all platform

Project Member Reported by xidac...@chromium.org, Aug 28
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5e21417ec6af5f457f1a5ee92bb5de90606bb0

commit 2b5e21417ec6af5f457f1a5ee92bb5de90606bb0
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Aug 28 15:22:44 2018

Disable PictureInPictureInBackgroundPage on all platform

TBR=beaufort.francois@gmail.com
NOTRY=true

Bug:  878396 
Change-Id: I6216c7273e514fde365f591b0607eb8a69ab133e
Reviewed-on: https://chromium-review.googlesource.com/1194243
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586714}
[modify] https://crrev.com/2b5e21417ec6af5f457f1a5ee92bb5de90606bb0/chrome/browser/extensions/lazy_background_page_apitest.cc

Comment 2 by fgor...@chromium.org, Aug 28

Cc: beaufort...@gmail.com
Owner: fbeaufort@chromium.org

Comment 3 by yutak@chromium.org, Aug 29 

 Issue 878427  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc

commit 4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 04 15:16:27 2018

Re-enable PictureInPictureInBackgroundPage test.

Instead of checking the keep_alive_count,
PictureInPictureInBackgroundPage test now checks that keep alive
activities contain Picture-in-Picture when video enters
Picture-in-Picture. This removes flakyness.

Bug:  878396 
Change-Id: I869506507ab82bcf0c973bd9399902d3cf4cf479
Reviewed-on: https://chromium-review.googlesource.com/1202043
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#588518}
[modify] https://crrev.com/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc/chrome/browser/extensions/lazy_background_page_apitest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc

commit 4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 04 15:16:27 2018

Re-enable PictureInPictureInBackgroundPage test.

Instead of checking the keep_alive_count,
PictureInPictureInBackgroundPage test now checks that keep alive
activities contain Picture-in-Picture when video enters
Picture-in-Picture. This removes flakyness.

Bug:  878396 
Change-Id: I869506507ab82bcf0c973bd9399902d3cf4cf479
Reviewed-on: https://chromium-review.googlesource.com/1202043
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#588518}
[modify] https://crrev.com/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc/chrome/browser/extensions/lazy_background_page_apitest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc

commit 4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 04 15:16:27 2018

Re-enable PictureInPictureInBackgroundPage test.

Instead of checking the keep_alive_count,
PictureInPictureInBackgroundPage test now checks that keep alive
activities contain Picture-in-Picture when video enters
Picture-in-Picture. This removes flakyness.

Bug:  878396 
Change-Id: I869506507ab82bcf0c973bd9399902d3cf4cf479
Reviewed-on: https://chromium-review.googlesource.com/1202043
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#588518}
[modify] https://crrev.com/4daaf1b731bb1d39fff93d2b207e4a81cf4cc7dc/chrome/browser/extensions/lazy_background_page_apitest.cc

Comment 7 by fbeaufort@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment