Create design doc for throttling network usage of ads.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a commit 7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a Author: John Delaney <johnidel@chromium.org> Date: Wed Jan 02 18:31:22 2019 Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource This CL is strictly a refactor that switches the Ads PLMO to count frame data using ResourceDataUseUpdate instead of OnLoadedResource. This will allow us to include incomplete resources and header bytes in future per-frame metrics. This will not change behavior of existing histograms at all. Bug: 878393 Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 Reviewed-on: https://chromium-review.googlesource.com/c/1372428 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619436} [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/renderer/page_load_metrics/page_resource_data_use.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/renderer/page_load_metrics/page_resource_data_use.h [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [add] https://crrev.com/7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a/chrome/test/data/ads_observer/docwrite_blank_frame.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfdcecaa65712156b555178c52916179b66d737d commit bfdcecaa65712156b555178c52916179b66d737d Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jan 02 20:09:30 2019 Revert "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource" This reverts commit 7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a. Reason for revert: Suspected to be causing failures on linux-xenial-rel builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/6048 Original change's description: > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > This CL is strictly a refactor that switches the Ads PLMO to count frame > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > allow us to include incomplete resources and header bytes in future > per-frame metrics. This will not change behavior of existing histograms > at all. > > Bug: 878393 > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619436} TBR=jkarlin@chromium.org,rsesek@chromium.org,johnidel@chromium.org Change-Id: Ic943a740afbe7305e12bf34ee783502158a11a3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878393 Reviewed-on: https://chromium-review.googlesource.com/c/1393527 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619475} [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/renderer/page_load_metrics/page_resource_data_use.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/renderer/page_load_metrics/page_resource_data_use.h [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/bfdcecaa65712156b555178c52916179b66d737d/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [delete] https://crrev.com/d387faf49936d80d16706e4595ef95a41db3248c/chrome/test/data/ads_observer/docwrite_blank_frame.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02979f898a6eb64990107c289fce5d12b0e7a16d commit 02979f898a6eb64990107c289fce5d12b0e7a16d Author: John Delaney <johnidel@chromium.org> Date: Thu Jan 03 21:27:55 2019 Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource" This is a reland of 7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a Original change's description: > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > This CL is strictly a refactor that switches the Ads PLMO to count frame > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > allow us to include incomplete resources and header bytes in future > per-frame metrics. This will not change behavior of existing histograms > at all. > > Bug: 878393 > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619436} TBR=rsesek@chromium.org Bug: 878393 Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a Reviewed-on: https://chromium-review.googlesource.com/c/1393530 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619760} [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/renderer/page_load_metrics/page_resource_data_use.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/renderer/page_load_metrics/page_resource_data_use.h [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [add] https://crrev.com/02979f898a6eb64990107c289fce5d12b0e7a16d/chrome/test/data/ads_observer/docwrite_blank_frame.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46010c3e48d6efb996f1e89c03924019bf7a5be4 commit 46010c3e48d6efb996f1e89c03924019bf7a5be4 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Jan 03 22:39:51 2019 Revert "Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource"" This reverts commit 02979f898a6eb64990107c289fce5d12b0e7a16d. Reason for revert: Causing failures on linux-xenial-rel bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/6075 Original change's description: > Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource" > > This is a reland of 7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a > > Original change's description: > > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > > > This CL is strictly a refactor that switches the Ads PLMO to count frame > > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > > allow us to include incomplete resources and header bytes in future > > per-frame metrics. This will not change behavior of existing histograms > > at all. > > > > Bug: 878393 > > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > > Commit-Queue: John Delaney <johnidel@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#619436} > > TBR=rsesek@chromium.org > > Bug: 878393 > Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a > Reviewed-on: https://chromium-review.googlesource.com/c/1393530 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619760} TBR=jkarlin@chromium.org,rsesek@chromium.org,johnidel@chromium.org Change-Id: Ia755a547df8982402942b3430e6680ed1e97f3a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878393 Reviewed-on: https://chromium-review.googlesource.com/c/1394949 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619789} [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/renderer/page_load_metrics/page_resource_data_use.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/renderer/page_load_metrics/page_resource_data_use.h [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/46010c3e48d6efb996f1e89c03924019bf7a5be4/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [delete] https://crrev.com/e965c1e1e813644fc7766d55230a867b20b1e1fc/chrome/test/data/ads_observer/docwrite_blank_frame.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dc542c3f73dbc82f62727fcc557c638f275534a commit 0dc542c3f73dbc82f62727fcc557c638f275534a Author: John Delaney <johnidel@chromium.org> Date: Fri Jan 04 22:22:27 2019 Reland "Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource"" This is a reland of 02979f898a6eb64990107c289fce5d12b0e7a16d Original change's description: > Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource" > > This is a reland of 7c6d18bae6b44aeadf1c5247ddcd74cd15a6a12a > > Original change's description: > > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > > > This CL is strictly a refactor that switches the Ads PLMO to count frame > > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > > allow us to include incomplete resources and header bytes in future > > per-frame metrics. This will not change behavior of existing histograms > > at all. > > > > Bug: 878393 > > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > > Commit-Queue: John Delaney <johnidel@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#619436} > > TBR=rsesek@chromium.org > > Bug: 878393 > Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a > Reviewed-on: https://chromium-review.googlesource.com/c/1393530 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619760} TBR=rsesek@chromium.org Bug: 878393 Change-Id: Ie3bb43fb5bd38b5085917d0b0df2461871482bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1396437 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#620082} [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/renderer/page_load_metrics/page_resource_data_use.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/renderer/page_load_metrics/page_resource_data_use.h [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [add] https://crrev.com/0dc542c3f73dbc82f62727fcc557c638f275534a/chrome/test/data/ads_observer/docwrite_blank_frame.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7302c33b4c9c9aebc0eaac6989f46932afd230f3 commit 7302c33b4c9c9aebc0eaac6989f46932afd230f3 Author: John Delaney <johnidel@chromium.org> Date: Thu Jan 17 04:38:47 2019 Record unfinished bytes in per-frame ads metrics To establish accurate percentiles for ad frames sizes, we should include unfinished resource bytes in metrics. Currently, videos that have not fully buffered are excluded from these metrics. In the future, we will need these numbers to establish proper thresholds for ad iframe network usage interventions. Because this will shift metrics, all histograms using ad frame sizes need to be renamed. Bug: 878393 Change-Id: I3661d5fa17665d6468b6f104be3d5388153433ba Reviewed-on: https://chromium-review.googlesource.com/c/1394953 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#623578} [modify] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [add] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/chrome/test/data/ads_observer/ad_with_incomplete_resource.html [modify] https://crrev.com/7302c33b4c9c9aebc0eaac6989f46932afd230f3/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Jan 2