New issue
Advanced search Search tips

Issue 878384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Wrong //ui/views/mus:mus_views_unittests dependency on //ui/views:test_support

Project Member Reported by tmonius...@opera.com, Aug 28

Issue description

I got this error on trybot (https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-jumbo-rel/65169):

FAILED: views_mus_unittests 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./views_mus_unittests" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./views_mus_unittests" -Wl,--start-group @"./views_mus_unittests.rsp"  -Wl,--end-group   -ldl -lpthread -lrt -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lexpat -luuid -lXrandr -lresolv -lgio-2.0 -lpci -lXss -lasound -lm -lz -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 
ld.lld: error: duplicate symbol: views::test::CreatePlatformNativeWidgetImpl(views::Widget::InitParams const&, views::Widget*, unsigned int, bool*)
>>> defined at native_widget_factory_aura_mus.cc:49 (./../../ui/views/test/native_widget_factory_aura_mus.cc:49)
>>>            test_support/test_support_jumbo_1.o:(views::test::CreatePlatformNativeWidgetImpl(views::Widget::InitParams const&, views::Widget*, unsigned int, bool*)) in archive obj/ui/views/mus/libtest_support.a
>>> defined at native_widget_factory_desktop.cc:23 (./../../ui/views/test/native_widget_factory_desktop.cc:23)
>>>            test_support/test_support_jumbo_1.o:(.text._ZN5views4test30CreatePlatformNativeWidgetImplERKNS_6Widget10InitParamsEPS1_jPb+0x0) in archive obj/ui/views/libtest_support.a
ld.lld: error: duplicate symbol: views::test::CreatePlatformDesktopNativeWidgetImpl(views::Widget::InitParams const&, views::Widget*, bool*)
>>> defined at native_widget_factory_aura_mus.cc:60 (./../../ui/views/test/native_widget_factory_aura_mus.cc:60)
>>>            test_support/test_support_jumbo_1.o:(views::test::CreatePlatformDesktopNativeWidgetImpl(views::Widget::InitParams const&, views::Widget*, bool*)) in archive obj/ui/views/mus/libtest_support.a
>>> defined at native_widget_factory_desktop.cc:36 (./../../ui/views/test/native_widget_factory_desktop.cc:36)
>>>            test_support/test_support_jumbo_1.o:(.text._ZN5views4test37CreatePlatformDesktopNativeWidgetImplERKNS_6Widget10InitParamsEPS1_Pb+0x0) in archive obj/ui/views/libtest_support.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
 
It seems native_widget_factory_aura_mus.cc and native_widget_factory_desktop.cc shouldn't be both compiled and linked.

native_widget_factory_desktop.cc is a part of //ui/views:test_support ans gn reports such dependency:

$ gn path out/Release //ui/views/mus:views_mus_unittests //ui/views:test_support
//ui/views/mus:views_mus_unittests --[private]-->
//ui/views:views_unittests_sources --[public]-->
//ui/views:test_support
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d91eb659b675663020aa3084f7d9c36754b618

commit 16d91eb659b675663020aa3084f7d9c36754b618
Author: Tomasz Moniuszko <tmoniuszko@opera.com>
Date: Thu Aug 30 08:46:17 2018

Fix views_mus_unittests dependency on views test support

Bug:  878384 
Change-Id: I9105fbf1d4dcd52037b2ab6a56a42f5c7124c380
Reviewed-on: https://chromium-review.googlesource.com/1194026
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#587486}
[modify] https://crrev.com/16d91eb659b675663020aa3084f7d9c36754b618/ui/views/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment