Tapping the status bar doesn't get the user out of fullscreen |
|||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Enter fullscreen (2) Tap the status bar What is the expected result? The application should exit fullscreen. What happens instead? Nothing
,
Aug 31
I believe this is a regression in 70 and is not reproducible in 69?
,
Aug 31
Yes, only reproduces in M70
,
Aug 31
,
Aug 31
reassigned to kkhorimoto@ since gambard@ appears to be OOO till September 11.
,
Aug 31
I have sent the CL to Kurt actually https://chromium-review.googlesource.com/c/chromium/src/+/1199162
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f9ed80cdce16f9fa8878d24d9191a471b085b57 commit 7f9ed80cdce16f9fa8878d24d9191a471b085b57 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Sep 11 10:52:40 2018 [iOS] Reset FullscreenModel when tapping status bar The button catching the taps when the toolbar is collapsed doesn't catch the taps on the status bar. This CL makes sure the toolbar is expanded when the status bar is tapped. Bug: 878382 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I71dd7af9ca7d2e47687887d69f11661c71e3d86c Reviewed-on: https://chromium-review.googlesource.com/1199162 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#590259} [modify] https://crrev.com/7f9ed80cdce16f9fa8878d24d9191a471b085b57/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm
,
Sep 11
,
Sep 11
Approved.
,
Sep 11
Sorry, let's get canary verification first.
,
Sep 12
I verified on Canary.
,
Sep 12
Ok approved, thanks.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2fe406cbd24f64f172de74e31014852522466c4 commit b2fe406cbd24f64f172de74e31014852522466c4 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 12 14:48:22 2018 [iOS] Reset FullscreenModel when tapping status bar The button catching the taps when the toolbar is collapsed doesn't catch the taps on the status bar. This CL makes sure the toolbar is expanded when the status bar is tapped. Bug: 878382 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I71dd7af9ca7d2e47687887d69f11661c71e3d86c Reviewed-on: https://chromium-review.googlesource.com/1199162 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590259}(cherry picked from commit 7f9ed80cdce16f9fa8878d24d9191a471b085b57) Reviewed-on: https://chromium-review.googlesource.com/1221846 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#328} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b2fe406cbd24f64f172de74e31014852522466c4/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm
,
Sep 14
Verified on chrome beta version 70.0.3538.17 on following step mentioned in comment #0, tapping on status bar exit full screen. Looks good. Devices : iPhone X, iPhone 6 plus, iPhone 6s plus, iPad Air iOS: 11.4.1, 12 beta 12, 10.3.3 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gambard@chromium.org
, Aug 31