New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878372 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857575



Sign in to add a comment

Advance fallback instead of clearing it

Project Member Reported by fsamuel@google.com, Aug 28

Issue description

DelegatedFrameHost(Android)::EmbedSurface currently clears the fallback if the client is hidden and there's a size change. This no longer has the desired effect. Instead, we should probably advance the fallback to match the primary.
 
Part of the reason this no longer has the desired effect is GetLatestInFlightSurface will still embed something even if there's no fallback.
Components: Internals>Compositing
Blocking: 857575
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77

commit fccd79a558e23ab2b6cd5a7d5f618e682efd8e77
Author: Saman Sami <samans@chromium.org>
Date: Tue Oct 09 23:09:37 2018

Fix content of old size shown on tab switch

Advance the fallback instead of clearing it because clearing it no
longer prevents surfaces older than primary being shown. Instead
we should set fallback to be the same as primary.

Bug:  878372 
Change-Id: I94988f554abf3132c5615094ce864a9ee55ca801
Reviewed-on: https://chromium-review.googlesource.com/c/1262956
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598124}
[modify] https://crrev.com/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/fccd79a558e23ab2b6cd5a7d5f618e682efd8e77/ui/android/delegated_frame_host_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment