Regression:[RTL]Arrow key navigation is not proper on chrome background overlay.
Reported by
vineetha...@etouch.net,
Aug 28
|
||||||
Issue descriptionChrome version : 70.0.3534.4 (Official Build) ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11}(32/64-bit) OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" flags and set Force UI direction to 'Right to Left' under chrome://flags. Steps to reproduce: 1. Launch chrome and open NTP. 2. Click on 'Gear' icon and click on 'Chrome backgrounds' . 3. Press 'down arrow' button on keyboard to get focus on one of the backgrounds. 4. Now press left arrow key and observe. Actual Result :On pressing left arrow key, focus navigates to the option present at the right. Expected Result:On pressing left arrow key, focus should travel to the option present to the left instead of right. This is a regression issue broken in ‘M-70’ and below is bisect info. Good build: 70.0.3503.0 Bad build: 70.0.3504.0 You are probably looking for a change made after 578169 (known good), but no later than 578170 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7637ae87b8e8ef651fdcd15e8ace6da78053e6b0..b315c20043e0a5ad29ed29ce7d47aaba043b8204 Suspect: https://chromium.googlesource.com/chromium/src/+/b315c20043e0a5ad29ed29ce7d47aaba043b8204 @kmilka: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: 1) On Mac OS, additional flag 'Enable RTL' needs to be enabled under chrome://flags. 2) Above issue is also reproducible after changing chrome language to any rtl language e.g: Arabic in Windows OS. Thank You
,
Aug 28
,
Aug 28
,
Aug 29
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fafc97a76623d9611f00d33726bf5bf2ea0b482f commit fafc97a76623d9611f00d33726bf5bf2ea0b482f Author: Weilun Shi <sweilun@chromium.org> Date: Wed Aug 29 00:09:59 2018 [NTP] Left key on custom background dialog should go left on RTL mode Make the keyboard navigation on custom background dialog correspond to RTL mode by checking if it is on rtl mode before getting the next tile. Bug: 878362 Change-Id: Ia6746cd4403ba84a8d39c714773e0275fb096bda Reviewed-on: https://chromium-review.googlesource.com/1194870 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#586948} [modify] https://crrev.com/fafc97a76623d9611f00d33726bf5bf2ea0b482f/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Aug 29
,
Aug 30
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)OS with Canary version #70.0.3536.0 and the issue is fixed. Kindly refer the attached screen cast. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ramyan@chromium.org
, Aug 28Labels: -Pri-1 Pri-2
Owner: sweilun@chromium.org