New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security



Sign in to add a comment

CVE-2018-13406 CrOS: Vulnerability reported in Linux kernel

Project Member Reported by vomit.go...@appspot.gserviceaccount.com, Aug 28

Issue description

VOMIT (go/vomit) has received an external vulnerability report for the Linux kernel. 

Advisory: CVE-2018-13406
  Details: http://vomit.googleplex.com/advisory?id=CVE/CVE-2018-13406
  CVSS severity score: 7.2/10.0
  Description:

An integer overflow in the uvesafb_setcmap function in drivers/video/fbdev/uvesafb.c in the Linux kernel before 4.17.4 could result in local attackers being able to crash the kernel or potentially elevate privileges because kmalloc_array is not used.



This bug was filed by http://go/vomit
Please contact us at vomit-team@google.com if you need any assistance.

 
Cc: groeck@chromium.org wonderfly@chromium.org
Labels: Security_Severity-High Security_Impact-Stable Pri-1
Owner: zsm@chromium.org
Status: Assigned (was: Untriaged)
Upstream commit is 9f645bcc56("video: uvesafb: Fix integer overflow in allocation"). The commit is present in v4.14, and v4.4.
v3.18 is affected and the patch cleanly applies.
Older kernels are not affected.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 29

Labels: M-68 Target-68
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b7ef347def87dc655235bbcef6f01e7a03db05c7

commit b7ef347def87dc655235bbcef6f01e7a03db05c7
Author: Kees Cook <keescook@chromium.org>
Date: Fri Aug 31 12:23:24 2018

UPSTREAM: video: uvesafb: Fix integer overflow in allocation

cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.

BUG= chromium:878353 
TEST=None

Change-Id: I6ccc2aba7365c45c6f3f0816b74042f874c1b187
Reported-by: Dr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2d7df48 ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
(cherry picked from commit 9f645bcc566a1e9f921bdae7528a01ced5bc3713)
Signed-off-by: Zubin Mithra <zsm@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1194382

[modify] https://crrev.com/b7ef347def87dc655235bbcef6f01e7a03db05c7/drivers/video/fbdev/uvesafb.c

Labels: Merge-Request-69
Cc: -wonderfly@chromium.org wonderfly@google.com
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 31

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: adityakali@google.com
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 5

Labels: -M-68 M-69 Target-69
Labels: Merge-Request-70
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: geohsu@chromium.org
geohsu@: can this patch be merged into stable?
Stable reviewers, could you approve for merge into stable?
#12: I think you mean stable release PMs, not reviewers

Thanks, yes, I meant stable release PMs.
Ping for stable release PMs. Kindly update the bug.
Cc: geo...@google.com
I pinged Geo on chat.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 4

Labels: merge-merged-release-R70-11021.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5667a3e8072f3e7c5a45cea952839d1f5edd4fe7

commit 5667a3e8072f3e7c5a45cea952839d1f5edd4fe7
Author: Kees Cook <keescook@chromium.org>
Date: Thu Oct 04 19:20:51 2018

UPSTREAM: video: uvesafb: Fix integer overflow in allocation

cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.

BUG= chromium:878353 
TEST=None

Change-Id: I6ccc2aba7365c45c6f3f0816b74042f874c1b187
Reported-by: Dr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2d7df48 ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
(cherry picked from commit 9f645bcc566a1e9f921bdae7528a01ced5bc3713)
Signed-off-by: Zubin Mithra <zsm@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1194382
(cherry picked from commit b7ef347def87dc655235bbcef6f01e7a03db05c7)
Reviewed-on: https://chromium-review.googlesource.com/c/1262238

[modify] https://crrev.com/5667a3e8072f3e7c5a45cea952839d1f5edd4fe7/drivers/video/fbdev/uvesafb.c

Status: Fixed (was: Assigned)
Labels: -Merge-Approved-70
Project Member

Comment 21 by sheriffbot@chromium.org, Oct 5

Labels: Restrict-View-SecurityNotify
Project Member

Comment 22 by sheriffbot@chromium.org, Jan 11

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment