New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878348 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 11
Cc:
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Simultaneously tapping on toolbar element and NTP elements tigger both actions.

Project Member Reported by vbarig...@chromium.org, Aug 28 
App Version: 69.0.3497.70 beta
iOS Version: 12 beta 10, 11.4.1
Device: iPhone, iPads
URL: 

Steps to reproduce:
  1.  Launch chrome
  2.  Simultaneously tap on toolbar element and NTP elements.

Observed results:
Notice that both the context menus are triggered.

Expected results:
Only 1 action to take place at a time

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M68
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69

Link to video/image:  https://drive.google.com/file/d/1Lss7vS6eFx-8mtHpzpG2uInYdZhbQaU5/view?usp=sharing

Comment 1 by twelling...@chromium.org, Aug 28

Labels: zine-triaged

Comment 2 by sczs@chromium.org, Aug 29

Cc: justincohen@chromium.org
Components: UI>Browser>Toolbar
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
gambard@ could you PTAL?

Comment 3 by marq@chromium.org, Sep 6

Labels: -Pri-2 Pri-1
It's also possible to tap on multiple toolbar buttons at once.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b62c199848d1c4bffae334b877f0aba10fd12cfe

commit b62c199848d1c4bffae334b877f0aba10fd12cfe
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Sep 11 12:46:43 2018

[iOS] Add exclusive touch to toolbar buttons

This CL enables the exclusive touch on the toolbar buttons. It won't
be possible to do two actions at the same time including a button.

Bug:  878348 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2a2e6f93cc42731ccd0d5730464cf0eb1ceca278
Reviewed-on: https://chromium-review.googlesource.com/1219487
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590278}
[modify] https://crrev.com/b62c199848d1c4bffae334b877f0aba10fd12cfe/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm

Comment 5 by gambard@chromium.org, Sep 11

Status: Fixed (was: Assigned)

Comment 6 by kariahda@chromium.org, Sep 20

Labels: Merge-TBD
Does this need to be merged to M70?

Comment 7 by gambard@chromium.org, Sep 20 

I don't think it is needed to merge this. Why do you think it should be merged?
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 2

Labels: -Merge-TBD
►

Sign in to add a comment