Findit has detected flake occurrences for the test OnDiskApp/NetworkContextConfigurationBrowserTest.Cache/2 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Id462de6d71029210a7af7a7ac3fa8f3de896d9d8 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQyNDkwL2Jyb3dzZXJfdGVzdHMvVDI1RWFYTnJRWEJ3TDA1bGRIZHZjbXREYjI1MFpYaDBRMjl1Wm1sbmRYSmhkR2x2YmtKeWIzZHpaWEpVWlhOMExrTmhZMmhsTHpJPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20OnDiskApp/NetworkContextConfigurationBrowserTest.Cache/2&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQyNDkwL2Jyb3dzZXJfdGVzdHMvVDI1RWFYTnJRWEJ3TDA1bGRIZHZjbXREYjI1MFpYaDBRMjl1Wm1sbmRYSmhkR2x2YmtKeWIzZHpaWEpVWlhOMExrTmhZMmhsTHpJPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f6659c59d89eeddc094edd5a8cbffadf2e8d988 commit 2f6659c59d89eeddc094edd5a8cbffadf2e8d988 Author: Matt Menke <mmenke@chromium.org> Date: Tue Aug 28 16:59:30 2018 NetworkContext*BrowserTest: Don't check disk cache after crash Crashing the network service just after completing a network request can corrupt the cache. Bug: 878346 Change-Id: Ic5dbc1ce88c7bb2b7b9ef3849e3cee2d8a45bf38 Reviewed-on: https://chromium-review.googlesource.com/1193967 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586753} [modify] https://crrev.com/2f6659c59d89eeddc094edd5a8cbffadf2e8d988/chrome/browser/net/network_context_configuration_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/054a10453e3497c0afc9911d2c119734de67176b commit 054a10453e3497c0afc9911d2c119734de67176b Author: Matt Menke <mmenke@chromium.org> Date: Tue Aug 28 18:42:28 2018 NetworkContext*BrowserTest: Don't check disk cache after crash Crashing the network service just after completing a network request can corrupt the cache. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1193967, where I accidentally only disabled one of the two tests that crash the network service and expect an on-disk cache cache to work aftwards. Also do some cleanup to the earlier fix (Renable the other test when the network service is crash but there's no on disk cache, remove dead code) Bug: 878346 Change-Id: I7f483443aec4b0e60abd344676d4d197344b1b7f Reviewed-on: https://chromium-review.googlesource.com/1194466 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586798} [modify] https://crrev.com/054a10453e3497c0afc9911d2c119734de67176b/chrome/browser/net/network_context_configuration_browsertest.cc
Comment 1 by markusheintz@chromium.org
, Aug 28Owner: mmenke@chromium.org
Status: Assigned (was: Available)