New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878345 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Aug 29
Cc:
yyushkina@chromium.org
kmilka@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [NTP] Spacebar key input cause both 'Customize this page' overlay and NTP scroll act at the same time

Reported by khushal....@etouch.net, Aug 28 
Chrome Version: 70.0.3534.4 (Official Build) Revision ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11} (32/64-bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Pre-condition:
1. Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/
2. Resize browser such that scrollbar appears on NTP.

What steps will reproduce the problem?
(1) Launch chrome and open NTP.
(2) Now traverse focus on gear icon and press 'Spacebar' from keyboard and Observe.

Actual Result: Spacebar key input cause both 'Customize this page' overlay and NTP scroll act at the same time.

Expected Result: Spacebar key input should cause only 'Customize this page' overlay open.

This is a Regression issue seen from 'M-69' and providing the bisect info below:
Good Build: 69.0.3460.0 (Revision: 567313)
Bad Build:  69.0.3461.0 (Revision: 567544)

You are probably looking for a change made after 567315 (known good), but no later than 567316 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/4c9d08451ef94d31e97f189343914cf5144ae5c4..3d5ded2211ad5fe773309a8923b96700b8ebed55

Suspect: https://chromium.googlesource.com/chromium/src/+/3d5ded2211ad5fe773309a8923b96700b8ebed55

@kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-69 Beta (build #69.0.3497.57) & M-70 Canary (build #70.0.3535.0).

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
5.8 MB View Download
Expected Video.mov
4.3 MB View Download

Comment 1 by ramyan@chromium.org, Aug 28

Cc: yyushkina@chromium.org kmilka@chromium.org
Labels: -Pri-1 -Target-69 Needs-Feedback Pri-2
Owner: sweilun@chromium.org
I can't repro this on 70.0.3535.0 on Mac. I can tab to the gear icon, then press space to focus on 'Chrome Backgrounds'. Pressing space after that has no effect. 

khushal.pawar@: please confirm that these are the only steps required to reproduce.


Reassigning to Weilun, since he's been working on scrolling-related items.

Comment 2 by sweilun@chromium.org, Aug 28

Status: Started (was: Assigned)
I am able to reproduce this one. But that requires you to minimize the window till the scroll bar on the NTP appear and tab to the gear icon, move the scrollbar to the top and hit the spacebar.

Comment 3 by ramyan@chromium.org, Aug 29

Labels: AddToRemoteNTP
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bfc871e960503fa8abd8225898386334b219e3c

commit 3bfc871e960503fa8abd8225898386334b219e3c
Author: Weilun Shi <sweilun@chromium.org>
Date: Wed Aug 29 01:45:47 2018

[NTP] Hitting spacebar on gear icon will not move the NTP

Fixing the unexpected behavior when hitting spacebar on gear icon casue
the scrollbar move on NTP by preventing the spacebar default behavior
on gear icon.

Bug:  878345 
Change-Id: If1223dee1beca7966150e98a307614e7acfbbfe0
Reviewed-on: https://chromium-review.googlesource.com/1194665
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586989}
[modify] https://crrev.com/3bfc871e960503fa8abd8225898386334b219e3c/chrome/browser/resources/local_ntp/custom_backgrounds.js

Comment 5 by sweilun@chromium.org, Aug 29

Status: Fixed (was: Started)

Comment 6 by khushal....@etouch.net, Aug 30

Labels: -Needs-Feedback TE-Verified-M70 TE-Verified-70.0.3536.0
Update:

Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version #70.0.3536.0 and the issue is found FIXED.
Hence, adding respective labels.

Please refer the attached screen-cast.

Thank You..!!
878345_Fixed Video.mov
1.4 MB View Download
►

Sign in to add a comment