New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878341 link

Starred by 1 user
Status: Fixed
Owner:
kmilka@chromium.org
Closed: Sep 27
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
█ sweilun@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression


Participants' hotlists:
NTP-Birthday-Polish


Sign in to add a comment

Regression : [NTP] Unnecessarily two focus highlights are seen at the same time on 'Select a collection' overlay.

Reported by rp...@etouch.net, Aug 28 
Version: 70.0.3534.4 (Official Build)Revision ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6)

Pre condition : Enable Google local NTP and New Tab Page Material Design Icons from chrome://flags.

What steps will reproduce the problem?
1. Launch chrome, open NTP and click on gear icon then select 'Choose background' option ('Select a collection' overlay will open).
2. Double click on any collection 
3. Now press 'Tab' key and then click and hold on back navigation arrow on 'Select a collection' overlay,observe
 
Actual: Unnecessarily two focus highlights are seen at the same time on clicking and holding on back navigation arrow
Expected: Two focus highlights should not be seen at the same time on clicking and holding on back navigation arrow

This is a Regression issue seen from 'M-70' and providing the bisect info below:
Good Build: 70.0.3503.0 (Revision: 578160)
Bad Build:  70.0.3504.0 (Revision: 578510)

You are probably looking for a change made after 578169 (known good), but no later than 578170 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/7637ae87b8e8ef651fdcd15e8ace6da78053e6b0..b315c20043e0a5ad29ed29ce7d47aaba043b8204

Suspect: https://chromium.googlesource.com/chromium/src/+/b315c20043e0a5ad29ed29ce7d47aaba043b8204

@kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-70 Canary (build #70.0.3535.0).

Kindly refer the attached screen-cast.

Thank You..!!
Actual_video.mp4
557 KB View Download
Expected_video.mp4
470 KB View Download
Actual_screenshot.png
336 KB View Download
Expected_screenshot.png
286 KB View Download

Comment 1 by ramyan@chromium.org, Aug 28

Cc: sweilun@chromium.org yyushkina@chromium.org
Labels: -Pri-1 Pri-2

Comment 2 by twelling...@chromium.org, Aug 28

Labels: zine-triaged

Comment 3 by yyushkina@chromium.org, Aug 30

Labels: -Pri-2 Pri-3
Quite the combo of actions required to encounter this polish issue so lowering priority.

Comment 4 by ramyan@chromium.org, Sep 12

Labels: -Target-70 Target-71
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6acd308d41f88690de0efc15052fd1b467e4450

commit f6acd308d41f88690de0efc15052fd1b467e4450
Author: Kyle Milka <kmilka@chromium.org>
Date: Thu Sep 27 23:11:34 2018

[NTP] Prevent double focus on back arrow

Prevent two focus indicators on the back arrow by making the grey circle
the tabbable element.

Bug:  878341 
Change-Id: Ib18aa4669d3f8ea39754bb2ecadafaf718fe3143
Reviewed-on: https://chromium-review.googlesource.com/1249834
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594909}
[modify] https://crrev.com/f6acd308d41f88690de0efc15052fd1b467e4450/chrome/browser/resources/local_ntp/custom_backgrounds.css
[modify] https://crrev.com/f6acd308d41f88690de0efc15052fd1b467e4450/chrome/browser/resources/local_ntp/custom_backgrounds.js
[modify] https://crrev.com/f6acd308d41f88690de0efc15052fd1b467e4450/chrome/browser/resources/local_ntp/local_ntp.html

Comment 6 by kmilka@chromium.org, Sep 27

Status: Fixed (was: Assigned)

Comment 7 by rp...@etouch.net, Sep 28

Labels: TE-Verified-M71 TE-Verified-71.0.3564.0
Update :
Rechecked this issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) using latest canary Chrome version : 71.0.3564.0 and the issue is fixed.Hence adding TE verified labels.
Kindly refer the attached screen cast.

Thank you.
Fixed_video.mp4
854 KB View Download
►

Sign in to add a comment