New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878338 link

Starred by 2 users
Status: Fixed
Owner:
yamaguchi@chromium.org
Closed: Sep 25
Cc:
ajha@chromium.org
yamaguchi@chromium.org
tetsui@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Notifications' tooltip is seen missing on hovering on Notification Number at Uber Tray

Project Member Reported by mmanchala@chromium.org, Aug 28 
Chrome Version:  70.0.3532.0/11010.0.0 dev-channel Celes,Candy and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download any Image or save any Image or Press 'Ctrl+F5(Overview Mode Button)' for screenshot -> Notification is seen 
(2)Now hover mouse pointer on Notification Number and observe for 'Notifications' tooltip
(Please refer Video)

Expected: 'Notifications' tooltip should be seen on hovering on Notification Number at Uber Tray
Actual: Instead on 'Notifications' tooltip is seen missing

This is Regression Issue as same is working fine in M-68
Actual_NoNotifications.mp4
9.2 MB View Download
Expected_Tooltip.mp4
6.1 MB View Download

Comment 1 by tetsui@chromium.org, Aug 28

Owner: tetsui@chromium.org

Comment 2 by tetsui@chromium.org, Sep 21

Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
Reassigning to yamaguchi@ who implemented the counter. Some tray icons have tooltips, so I guess we can do that for new notification number counter.

yamaguchi@: Could you take a look? Thank you.

Comment 3 by yamaguchi@chromium.org, Sep 21

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a047f6f2084cffef50a8ce143babb9934f864c7b

commit a047f6f2084cffef50a8ce143babb9934f864c7b
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Sep 21 08:33:36 2018

Unified: Add tooltip to the notification icon in status tray.

This only adds "Notifications" tooltip, not describing the count or DnD
status. Also screenreaders will also read the icon as "Notifications"
instead of just "image".

Bug:  878338 
Change-Id: Ic8da790d85c950f5c2565bc7c88eb1ebccfd41f3
Reviewed-on: https://chromium-review.googlesource.com/1237735
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593119}
[modify] https://crrev.com/a047f6f2084cffef50a8ce143babb9934f864c7b/ash/system/unified/notification_counter_view.cc

Comment 5 by yamaguchi@chromium.org, Sep 21

Labels: Merge-Request-70

Comment 6 by geo...@google.com, Sep 21

Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 25

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b500fe0909bab6627d8b68033b0c71271b6b42

commit 03b500fe0909bab6627d8b68033b0c71271b6b42
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Sep 25 04:34:32 2018

Unified: Add tooltip to the notification icon in status tray.

This only adds "Notifications" tooltip, not describing the count or DnD
status. Also screenreaders will also read the icon as "Notifications"
instead of just "image".

Bug:  878338 
Change-Id: Ic8da790d85c950f5c2565bc7c88eb1ebccfd41f3
Reviewed-on: https://chromium-review.googlesource.com/1237735
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593119}(cherry picked from commit a047f6f2084cffef50a8ce143babb9934f864c7b)
Reviewed-on: https://chromium-review.googlesource.com/1242255
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#645}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/03b500fe0909bab6627d8b68033b0c71271b6b42/ash/system/unified/notification_counter_view.cc
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Sep 25

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/03b500fe0909bab6627d8b68033b0c71271b6b42

Commit: 03b500fe0909bab6627d8b68033b0c71271b6b42
Author: yamaguchi@chromium.org
Commiter: yamaguchi@chromium.org
Date: 2018-09-25 04:34:32 +0000 UTC

Unified: Add tooltip to the notification icon in status tray.

This only adds "Notifications" tooltip, not describing the count or DnD
status. Also screenreaders will also read the icon as "Notifications"
instead of just "image".

Bug:  878338 
Change-Id: Ic8da790d85c950f5c2565bc7c88eb1ebccfd41f3
Reviewed-on: https://chromium-review.googlesource.com/1237735
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593119}(cherry picked from commit a047f6f2084cffef50a8ce143babb9934f864c7b)
Reviewed-on: https://chromium-review.googlesource.com/1242255
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#645}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Comment 9 by yamaguchi@chromium.org, Sep 25

Status: Fixed (was: Started)
►

Sign in to add a comment