New issue
Advanced search Search tips

Issue 878331 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Sep 21
Cc:
aee@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus is seen chopped on iron icon in chrome://settings/content/notifications page.

Reported by db...@etouch.net, Aug 28 
Chrome Version:70.0.3534.4 Revision ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11}(64 bit)
OS: Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings/content/notifications page.
(2) Press 'Tab' key upto focus reaches to iron icon, observe focus on it.

Actual: Focus is seen chopped on iron icon.

Expected: Focus should seen properly on iron icon.

This is a regression issue broken in ‘M-70’ and using per-revision bisect providing the bisect results,
Good Build: 70.0.3501.0
Bad Build: 70.0.3502.0

You are probably looking for a change made after 577742 (known good), but no later than 577743 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b3d2f01439976295d1a529f29f2dd7ebe4482caf..fc566d1c1a2d8da82ccce610b153f3b54524eab4

Suspect: https://chromium.googlesource.com/chromium/src/+/fc566d1c1a2d8da82ccce610b153f3b54524eab4

aee@Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS.


Thank You!
Actual_Focus.mov
2.2 MB View Download
Expected_Focus.mov
1.5 MB View Download

Comment 1 by aee@chromium.org, Aug 29

Status: Started (was: Assigned)
Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/1195674.
focus_outline.png
46.9 KB View Download

Comment 2 by aee@chromium.org, Aug 29 

The icon is separately getting focus from the cr-policy-pref-indicator. This causes problems with the FocusRowBehavior. Removing tabindex from the icon so the focus can propagate up to the site-list-entry's cr-policy-pref-indicator component.

Comment 3 by aee@chromium.org, Aug 29

Cc: aee@chromium.org
 Issue 877891  has been merged into this issue.

Comment 4 by aee@chromium.org, Aug 29 

 Issue 877421  has been merged into this issue.

Comment 5 by aee@chromium.org, Aug 29 

Also note that the focus should be controlled using the arrow keys in the iron-list. Tab should focus on the next element after the iron-list.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647d0eba90962cf3e070fc20fe9c5666f1e65000

commit 647d0eba90962cf3e070fc20fe9c5666f1e65000
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Sep 21 17:25:28 2018

Site Settings WebUI: padding for policy indicator outline when last

Also fixing focus issue with cr-policy-pref-indicator. Need to pass
make a function that returns the iron-icon that is the focusable
element and is within the shadow DOM.

Bug:  878331 
Change-Id: I4c04aae355e713a086e69df3dd480193005b72b3
Reviewed-on: https://chromium-review.googlesource.com/1195674
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593241}
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/chrome/browser/resources/settings/focus_row_behavior.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/chrome/browser/resources/settings/site_settings/site_list_entry.html
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/chrome/test/data/webui/settings/focus_row_behavior_test.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/ui/webui/resources/cr_elements/policy/BUILD.gn
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/ui/webui/resources/js/cr/ui/focus_grid.js
[modify] https://crrev.com/647d0eba90962cf3e070fc20fe9c5666f1e65000/ui/webui/resources/js/cr/ui/focus_row.js

Comment 7 by aee@chromium.org, Sep 21

Status: Fixed (was: Started)
►

Sign in to add a comment