Regression : PDF 'Bookmarks' list items disappear after scrolling the list Up and Down.
Reported by
avsha...@etouch.net,
Aug 28
|
|||||
Issue descriptionChrome Version : 70.0.3534.4 (Official Build) ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac Mini (10.13.1, 10.12.6) Test URL : http://cb.vu/unixtoolbox.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on 'Bookmarks' icon seen on the PDF toolbar and expand first 2 - 3 entries in the list. 3. Scroll the bookmarks list up & down using mouse and observe. Actual Result : PDF 'Bookmarks' list items disappear after scrolling the list Up and Down. Expected Result : 'Bookmarks' list should not turn blank after scrolling the list Up and Down. This is a regression issue broken in ‘M-70’ and below is the 'per-revision' bisect information: Good Build : 70.0.3517.0 (Revision : 581730) Bad Build : 70.0.3518.0 (Revision : 582029) Change Log URL : https://chromium.googlesource.com/chromium/src/+log/e512c651c9c361f1c8dee74008f5399f2384af30..7a4adf03f8af3f368e46c8df21bb7f8182d9e1fe Suspecting : rhttps://chromium.googlesource.com/chromium/src/+/7a4adf03f8af3f368e46c8df21bb7f8182d9e1fe Chris @ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. In Linux(14.04 LTS) OS, sightly different behavior is observed. While scrolling the 'Bookmarks' list, only 'Expand' / 'Collapse' arrow icons disappear but the item name stays visible. 2. This issue is not observed in Mac(10.14) Retina and Mac Touch-bar (10.13.6) OS. 3. Issue is reproducible in latest Canary build #70.0.3535.0
,
Aug 28
I think the bug in this case is failure to invalidate the ancestor clipping mask layer, which has scroll offset baked into it.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc14c4224961fc7b2b52db1bdb088fc471919ed9 commit fc14c4224961fc7b2b52db1bdb088fc471919ed9 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Aug 31 17:50:04 2018 Re-compute LayerState for ancestor clipping mask layer when it changes position. Other layers with LayerState already have such logic, this one was missed. The problem exhibits in particular on non-composited scroll of the clipping ancestor. Bug: 878330 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I05c21d81a2493bbfa86f031212b61a5b973c768c Reviewed-on: https://chromium-review.googlesource.com/1198566 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588080} [add] https://crrev.com/fc14c4224961fc7b2b52db1bdb088fc471919ed9/third_party/WebKit/LayoutTests/compositing/masks/ancestor-clipping-mask-non-composited-scroll-expected.html [add] https://crrev.com/fc14c4224961fc7b2b52db1bdb088fc471919ed9/third_party/WebKit/LayoutTests/compositing/masks/ancestor-clipping-mask-non-composited-scroll.html [modify] https://crrev.com/fc14c4224961fc7b2b52db1bdb088fc471919ed9/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
,
Aug 31
,
Sep 1
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
Fixed: https://chromium.googlesource.com/chromium/src/+/8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e
,
Sep 5
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e commit 8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Sep 04 17:21:19 2018 Re-compute LayerState for ancestor clipping mask layer when it changes position. Other layers with LayerState already have such logic, this one was missed. The problem exhibits in particular on non-composited scroll of the clipping ancestor. Bug: 878330 TBR=chrishtr@chromium.org (cherry picked from commit fc14c4224961fc7b2b52db1bdb088fc471919ed9) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I05c21d81a2493bbfa86f031212b61a5b973c768c Reviewed-on: https://chromium-review.googlesource.com/1198566 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588080} Reviewed-on: https://chromium-review.googlesource.com/1204594 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#28} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [add] https://crrev.com/8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e/third_party/WebKit/LayoutTests/compositing/masks/ancestor-clipping-mask-non-composited-scroll-expected.html [add] https://crrev.com/8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e/third_party/WebKit/LayoutTests/compositing/masks/ancestor-clipping-mask-non-composited-scroll.html [modify] https://crrev.com/8d32cb5c0398de57bc3373dd7bb6faf2c1800f8e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Aug 28Labels: ReleaseBlock-Stable