New issue
Advanced search Search tips

Issue 878328 link

Starred by 3 users
Status: Fixed
Owner:
jkarlin@chromium.org
Closed: Aug 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"FilterToolTest.MatchRules" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 28 
"FilterToolTest.MatchRules" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJAsSBUZsYWtlIhlGaWx0ZXJUb29sVGVzdC5NYXRjaFJ1bGVzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by dullweber@chromium.org, Aug 28

Owner: jkarlin@chromium.org
The test just flaked on a trybot. 
jkarlin@: It looks like you worked on it recently

Comment 2 by jkarlin@chromium.org, Aug 28

Status: Started (was: Untriaged)
Thanks for the report. Easy fix, CL is up: https://chromium-review.googlesource.com/1193902
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d9a948a3882a64f6d164091ab29b7c8eecf3d5

commit f4d9a948a3882a64f6d164091ab29b7c8eecf3d5
Author: Josh Karlin <jkarlin@chromium.org>
Date: Tue Aug 28 14:49:06 2018

[AdTagging] Make a filter tool test deterministic

The MatchRules test had non-deterministic sorting behavior on
different platforms. Fix this by avoiding situations in the test where
there are ties for the number of matches.

Bug:  878328 ,  877148 
Change-Id: I4883141c0c5c8ab02ace9365b4a446f132d6cea1
Reviewed-on: https://chromium-review.googlesource.com/1193902
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586697}
[modify] https://crrev.com/f4d9a948a3882a64f6d164091ab29b7c8eecf3d5/components/subresource_filter/tools/filter_tool_unittest.cc

Comment 4 by jkarlin@chromium.org, Aug 28

Status: Fixed (was: Started)
►

Sign in to add a comment