New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878324 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 914616



Sign in to add a comment

Share Downloads with crostini container

Project Member Reported by joelhockey@chromium.org, Aug 28

Issue description

Allow directories under Downloads to be shared with crostini container
 
Showing comments 35 - 134 of 134 Older
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 53 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 54 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 55 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 56 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 58 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 59 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 60 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3330ab57611b2c8b19d0630b4daaee03cf58fa5f

commit 3330ab57611b2c8b19d0630b4daaee03cf58fa5f
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Sep 03 21:18:23 2018

FilesApp add directory 'Share with Linux' command

Calls fileManagerPrivate.sharePathWithCrostiniContainer
to share directory.

Bug:  878324 
Change-Id: Id0e75173b8650c21866fb1903171efa44be06a2c
Reviewed-on: https://chromium-review.googlesource.com/1195406
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588433}
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_WITH_LINUX_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/3330ab57611b2c8b19d0630b4daaee03cf58fa5f/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 63 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b

commit 479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Sep 11 05:49:08 2018

CrOS FilesApp: Crostini shared path management

New JS class Crostini to manage crostini shared paths.
Record paths that are shared, and do not show 'Share with Linux'
option for paths that are already shared.

Update Crostini UI test:
 * Verify that 'Share with Linux' is not shown for files (only dirs).
 * Fixed drive_welcome.css path.

Bug:  878324 
Change-Id: I6b8445d0a127043f9d24126384267284af5ed7ab
Reviewed-on: https://chromium-review.googlesource.com/1215154
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590211}
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/constants.js
[add] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/crostini.js
[add] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/crostini_unittest.html
[add] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/foreground/js/ui/banners.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/479efc9a8f5b0afc1cd06e68c0fa041b17dd9c4b/ui/file_manager/file_manager/test/js/test_util.js

Responding to #c12: Sorry Daniel, I only just noticed your question now.  The plan is to make this feature available to be able to share Drive, Play files, and removable drives.  The term 'provided' filesystem has a special meaning for FilesApp.  We wont be sharing filesystems that are implemented as https://developer.chrome.com/apps/fileSystemProvider.
Project Member

Comment 66 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee2de1f071c76b3515c743e85aa6ca9e9d28d84

commit dee2de1f071c76b3515c743e85aa6ca9e9d28d84
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Sep 18 21:41:52 2018

Crostini: remount persisted shared folders at startup

Note that this feature is being added to read any persisted shares,
however support to write shares as persisted will not be added
until the management UI where shares can be removed is completed.

* prefs: crostini.shared_paths will be a list of filesystem path strings.
* New function CrostiniSharePath::GetSharedPaths() reads from prefs.
* New fileManagerPrivate.getCrostiniSharedPaths executes
  callback to receive list of Entry.
* FileManager.setupCrostini_ loads persisted shares at startup.
* FileManagerApiTest.Crostini verifies reading from prefs and correct
  conversion of filesystem paths to FileEntry.
* New integration test for fileManagerPrivate.getCrostiniSharedPaths().


Bug:  878324 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5c8ee8193eb2fda94e5505d79b449797fbab9449
Reviewed-on: https://chromium-review.googlesource.com/1220411
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592208}
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/crostini/crostini_pref_names.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/crostini/crostini_pref_names.h
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/common/extensions/api/file_manager_private_internal.idl
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/file_manager/test/js/strings.js
[modify] https://crrev.com/dee2de1f071c76b3515c743e85aa6ca9e9d28d84/ui/file_manager/integration_tests/file_manager/crostini.js

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/455760fe5861e99832742912d0af5a0440b6ce60

commit 455760fe5861e99832742912d0af5a0440b6ce60
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Sep 20 08:51:17 2018

Crostini: re-share all paths with container at startup

Read list of persisted shared paths from prefs, and re-share
with seneschal/9p when container starts.

Bug:  878324 
Change-Id: Iea0ff71b79e5787d06b9d1b42a985cea2fb2631b
Reviewed-on: https://chromium-review.googlesource.com/1232793
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592724}
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js

Project Member

Comment 69 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec38a719c28709cbad53804e18db9e96a121c21

commit dec38a719c28709cbad53804e18db9e96a121c21
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 02 22:13:34 2018

CrOS FilesApp: Share crostini entries before opening

When a user opens files within Downloads using a crostini app,
show a dialog for the user to give permission to share the
directory that the files are in with crostini.

* Move handling of 'crostin-files' flag checking into
  foreground/js/crostini.js
* Change FileTasks.executeInternal to detect files that
  can be shared with crostini and do sharing before execute.
* UI Test verifies share dialog is shown before execute.
* ConvertFileSystemURLToPathInsideCrostini maps
  path from within Downloads to '/ChromeOS/Downloads/...'

Bug:  878324 
Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210
Reviewed-on: https://chromium-review.googlesource.com/c/1243871
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596003}
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_MULTIPLE.png.sha1
[add] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_SINGLE.png.sha1
[add] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_TITLE.png.sha1
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/browser/chromeos/crostini/crostini_util.h
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/crostini_unittest.html
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/dec38a719c28709cbad53804e18db9e96a121c21/ui/file_manager/file_manager/test/js/test_util.js

Project Member

Comment 70 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b267c207354cc01f8c39c118e3e7cd8ffcea08

commit 32b267c207354cc01f8c39c118e3e7cd8ffcea08
Author: Alexey Baskakov <loyso@chromium.org>
Date: Wed Oct 03 00:28:15 2018

Revert "CrOS FilesApp: Share crostini entries before opening"

This reverts commit dec38a719c28709cbad53804e18db9e96a121c21.

Reason for revert: Crashes browser_tests.

Example:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933735011043353616/+/steps/browser_tests/0/stdout

Original change's description:
> CrOS FilesApp: Share crostini entries before opening
> 
> When a user opens files within Downloads using a crostini app,
> show a dialog for the user to give permission to share the
> directory that the files are in with crostini.
> 
> * Move handling of 'crostin-files' flag checking into
>   foreground/js/crostini.js
> * Change FileTasks.executeInternal to detect files that
>   can be shared with crostini and do sharing before execute.
> * UI Test verifies share dialog is shown before execute.
> * ConvertFileSystemURLToPathInsideCrostini maps
>   path from within Downloads to '/ChromeOS/Downloads/...'
> 
> Bug:  878324 
> Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210
> Reviewed-on: https://chromium-review.googlesource.com/c/1243871
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596003}

TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org,lucmult@chromium.org

Change-Id: I553be4bfe6c0fad8435383c70b44a420237b250b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  878324 
Reviewed-on: https://chromium-review.googlesource.com/c/1258622
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596067}
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/app/file_manager_strings.grdp
[delete] https://crrev.com/758003297868f2c02adcf4fec07ee9ebdef666f6/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_MULTIPLE.png.sha1
[delete] https://crrev.com/758003297868f2c02adcf4fec07ee9ebdef666f6/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_SINGLE.png.sha1
[delete] https://crrev.com/758003297868f2c02adcf4fec07ee9ebdef666f6/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_TITLE.png.sha1
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/browser/chromeos/crostini/crostini_util.h
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/crostini_unittest.html
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/32b267c207354cc01f8c39c118e3e7cd8ffcea08/ui/file_manager/file_manager/test/js/test_util.js

Project Member

Comment 71 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26513fe2d836c2abdf979ffe3df023c0f513185

commit a26513fe2d836c2abdf979ffe3df023c0f513185
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 03 03:22:34 2018

Reland "CrOS FilesApp: Share crostini entries before opening"

This is a reland of dec38a719c28709cbad53804e18db9e96a121c21

Failure was flaking in test FileManagerUITest.Crostini which was
caused by dialogs not being fully cleared before a new dialog
was being shown.

This is fixed by changing the test code to wait for the dialog
elements to be fully removed from the dom:
  assertTrue(test.fakeMouseClick('button.cr-dialog-ok'));
  test.waitForElementLost('.cr-dialog-container');
rather than just waiting for the .shown class to be removed:
  assertTrue(test.fakeMouseClick('button.cr-dialog-ok'));
  test.waitForElementLost('.cr-dialog-container.shown')

The behaviour that we were getting was:
1/ show dialog1: adds div.cr-dialog-container.shown to body
2/ test clicks on OK button to close dialog1.
3a/ dialog1 div.cr-dialog-container removes .shown attr
   The removal of the dialog div is delayed by design.
4/ next test show dialog2: 2nd div.cr-dialog-container added to body
5/ test clicks on OK button to close dialog2, but actually
   ends up clicking on dialog1
6/ Error at https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/dialogs.js?l=262&rcl=e20c6e8387cdccf61eef8615ac2b3b0a582b156b
3b/ dialog1 div finally removed from dom.


Original change's description:
> CrOS FilesApp: Share crostini entries before opening
>
> When a user opens files within Downloads using a crostini app,
> show a dialog for the user to give permission to share the
> directory that the files are in with crostini.
>
> * Move handling of 'crostin-files' flag checking into
>   foreground/js/crostini.js
> * Change FileTasks.executeInternal to detect files that
>   can be shared with crostini and do sharing before execute.
> * UI Test verifies share dialog is shown before execute.
> * ConvertFileSystemURLToPathInsideCrostini maps
>   path from within Downloads to '/ChromeOS/Downloads/...'
>
> Bug:  878324 
> Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210
> Reviewed-on: https://chromium-review.googlesource.com/c/1243871
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596003}

Bug:  878324 
Change-Id: Ied6225dca13a244ebbdbfa291fdd789d762ee140
Tbr: nverne@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1258683
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596109}
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_MULTIPLE.png.sha1
[add] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_SINGLE.png.sha1
[add] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_TITLE.png.sha1
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/browser/chromeos/crostini/crostini_util.h
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/crostini_unittest.html
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/a26513fe2d836c2abdf979ffe3df023c0f513185/ui/file_manager/file_manager/test/js/test_util.js

Labels: -M-71 M-72
 Issue 867457  has been merged into this issue.
Due to ChromeOS nature and for a smoother experience it would be important to have access to Google Drive files from the container. 

Related  issue 890649 :
 https://bugs.chromium.org/p/chromium/issues/detail?id=890649

regards.
@74 - I would like to see both. Drive is great but I am not sure how it would work when the Chromebook is offline. The Downloads, External Storage (MicroSD/USB Flash Drives, USB Hard Drives), Network Shares (FTP, NTFS, SSH, NFS and SMB) and Google Drive.
@75 You can always set important files to be available offline. 
ChromeOS is based on Cloud principles and having to manually sync files to google drive is not something practical.  

I believe Downloads was supposed to be something "temporary" and, although most higher end chromebooks do have enough storage, I believe the best approach is to save on cloud with offline availability managed by the OS and not the user. 
Project Member

Comment 77 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031609b88d700e0eca91bacc33e2b9bcfd34cdaf

commit 031609b88d700e0eca91bacc33e2b9bcfd34cdaf
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Oct 11 00:01:33 2018

CrOS Settings: Crostini shared files settings page

Added new 'Manage files & folders' section to crostini settings page.
This shows which folders from Chrome OS (e.g. Downloads/foo) are shared
with crostini, and allows the unshare them.

Bug:  878324 
Change-Id: I7d8090d84024c7ca834ef614da14297eb0a2ed69
Reviewed-on: https://chromium-review.googlesource.com/c/1270380
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598578}
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/app/settings_strings.grdp
[add] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_SHARED_PATHS.png.sha1
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/BUILD.gn
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_browser_proxy.js
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_page.html
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_page.js
[add] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_shared_paths.html
[add] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_shared_paths.js
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_subpage.html
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/crostini_page/crostini_subpage.js
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/ui/webui/settings/chromeos/crostini_handler.cc
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/ui/webui/settings/chromeos/crostini_handler.h
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/test/data/webui/settings/crostini_page_test.js
[modify] https://crrev.com/031609b88d700e0eca91bacc33e2b9bcfd34cdaf/chrome/test/data/webui/settings/test_crostini_browser_proxy.js

Project Member

Comment 79 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f85216b7109c2920950b064740a39f0d8f3e14b

commit 6f85216b7109c2920950b064740a39f0d8f3e14b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Oct 11 00:51:54 2018

CrOS save crostini shared paths to prefs

Once path has been validated, save it to prefs.  Even if the call
to seneschal fails, the path should be saved.

Bug:  878324 
Change-Id: Ifdf7270b39031c3c8b4a6cd1fbad5e2005a0f194
Reviewed-on: https://chromium-review.googlesource.com/c/1270557
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598602}
[modify] https://crrev.com/6f85216b7109c2920950b064740a39f0d8f3e14b/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/6f85216b7109c2920950b064740a39f0d8f3e14b/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/6f85216b7109c2920950b064740a39f0d8f3e14b/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js

Project Member

Comment 80 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83e0cbb508d756326ef59edddd4644afc7861839

commit 83e0cbb508d756326ef59edddd4644afc7861839
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Oct 11 01:59:46 2018

CrOS FilesApp: Crostini UMAs

Added 3 FilesApp Crostini UMAs.

1/ Updated FileBrowser.MenuItemSelected to add 'Share with Linux'

2/ FileBrowser.CrostiniShareDialog reports either:
 * None - no dialog shown when using crostini app to open file.
   This indicates that the path is already shared.
 * Share before open - the share before open dialog is shown
 * Unable to open - shown when multiple files from different
   unshared directories are opened.

In order to implement this UMA correctly, the call to
maybeShowCrostiniShareDialog_ has been moved outside of
executeInternal_ so that these functions no longer call each
other recursively.

3/ FileBrowser.CrostiniSharedPaths.Depth.[downloads|drive|other]
tracks the depth from volume root of each path shared with crostini.
This is equivalent to how many '/' are in the path.  E.g. 'Downloads'
or 'My Drive' has depth 0.  'Downloads/foo/bar' has depth 2.

Currently dedicated histograms are created to track downloads and drive
with all other volumes captured together.  Dedicated histograms
can be created in the future for other volume types.

Bug:  878324 
Change-Id: I0feb6d2652cce023d33aad254726068ad8da7e32
Reviewed-on: https://chromium-review.googlesource.com/c/1273155
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598631}
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/83e0cbb508d756326ef59edddd4644afc7861839/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js

Project Member

Comment 81 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2500163be8a63b6dd75c9427640f8763d6d46b33

commit 2500163be8a63b6dd75c9427640f8763d6d46b33
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Oct 12 04:53:58 2018

CrOS FilesApp: refactor only: split out crostini UI tests

Split crostini UI tests from crostini.js into test files:
 * crostini_mount.js
 * crostini_share.js
 * crostini_tasks.js
The existing tests are getting a bit too large and pushing
the bot testing time limits.

Bug:  878324 
Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383
Reviewed-on: https://chromium-review.googlesource.com/c/1278429
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599098}
[modify] https://crrev.com/2500163be8a63b6dd75c9427640f8763d6d46b33/chrome/browser/chromeos/file_manager/file_manager_uitest.cc
[modify] https://crrev.com/2500163be8a63b6dd75c9427640f8763d6d46b33/ui/file_manager/file_manager/test/BUILD.gn
[delete] https://crrev.com/dfeab488cdc95233b19b9edeedef3d0b7581b17e/ui/file_manager/file_manager/test/crostini.js
[add] https://crrev.com/2500163be8a63b6dd75c9427640f8763d6d46b33/ui/file_manager/file_manager/test/crostini_mount.js
[add] https://crrev.com/2500163be8a63b6dd75c9427640f8763d6d46b33/ui/file_manager/file_manager/test/crostini_share.js
[add] https://crrev.com/2500163be8a63b6dd75c9427640f8763d6d46b33/ui/file_manager/file_manager/test/crostini_tasks.js

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/836e5cd90af24fa6af71e4e633d1c0fb41ca0765

commit 836e5cd90af24fa6af71e4e633d1c0fb41ca0765
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Oct 12 07:33:06 2018

CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

Shown when crostini and flag crostini-files are enabled.
Links to chrome://settings/crostini/crostiniShared.
Record UMA for clicks.

Bug:  878324 
Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
Reviewed-on: https://chromium-review.googlesource.com/c/1277130
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599128}
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/836e5cd90af24fa6af71e4e633d1c0fb41ca0765/ui/file_manager/file_manager/test/crostini_share.js

Project Member

Comment 83 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250d12a48cb24d7621b01bce5818a78a88780a65

commit 250d12a48cb24d7621b01bce5818a78a88780a65
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 23 10:34:54 2018

Add better error checking in ConvertFileSystemURLToPathInsideCrostini

Change method API to take resulting FilePath as input pointer, and
return bool to indicate success or otherwise since it is not
guaranteed that input will always convert.

Bug:  878324 
Change-Id: I17f99201c2c4b5105cceb48d6a3c0d57b80c5f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1295634
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601903}
[modify] https://crrev.com/250d12a48cb24d7621b01bce5818a78a88780a65/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/250d12a48cb24d7621b01bce5818a78a88780a65/chrome/browser/chromeos/file_manager/crostini_file_tasks.cc
[modify] https://crrev.com/250d12a48cb24d7621b01bce5818a78a88780a65/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/250d12a48cb24d7621b01bce5818a78a88780a65/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/250d12a48cb24d7621b01bce5818a78a88780a65/chrome/browser/chromeos/file_manager/path_util_unittest.cc

Project Member

Comment 84 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd

commit a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 23 20:01:45 2018

system_api: seneschal: New storage_locations in seneschal .proto

Added DRIVEFS_* and REMOVABLE storage location types.

BUG= chromium:878324 
BUG= chromium:890649 
TEST=Install on device, test sharing with FilesApp

Change-Id: I9fd0a4e4b3b5bbd5c299139071de4a7b4f35f094
Reviewed-on: https://chromium-review.googlesource.com/1287389
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd/system_api/dbus/seneschal/seneschal_service.proto

Project Member

Comment 85 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44eda7de117c38874d48e466e3f2091aede357b8

commit 44eda7de117c38874d48e466e3f2091aede357b8
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 23 23:47:40 2018

Roll src/third_party/cros_system_api/ 299607e8f..c270bd3da (5 commits)

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/299607e8f0fa..c270bd3daa83

$ git log 299607e8f..c270bd3da --date=short --no-merges --format='%ad %ae %s'
2018-10-17 allenwebb session_manager: Add IsScreenLocked() dbus method.
2018-10-22 joelhockey system_api: seneschal: New storage_locations in seneschal .proto
2018-10-22 xiaochu system_api: add dlcservice d-bus constants&protobuf
2018-10-19 benchan system_api: shill: remove unused kConfigureWifiServiceFunction constant
2018-10-11 derat power: Delete old SetScreenBrightnessPercent method.

Created with:
  roll-dep src/third_party/cros_system_api

Bug:  878324 
Change-Id: I95473cc6f9e4a2fa894168c5f6b6c893a745020d
Reviewed-on: https://chromium-review.googlesource.com/c/1297210
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602175}
[modify] https://crrev.com/44eda7de117c38874d48e466e3f2091aede357b8/DEPS

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8aca8932147701179a70ae362fb2285b13ebd53

commit b8aca8932147701179a70ae362fb2285b13ebd53
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 05:09:16 2018

CrOS FilesApp: Make persist optional for crostini path sharing

Only persist shares from right-click > Share with Linux.
Do not persist shares that are done for the purpose of
opening a file with a linux app.

Share with Linux is only supported for directories (not files),
but open with linux app will share only the selected files, and
not the containing directories.

Also needed to fix chrome.fileManagerPrivate.executeTask jsdoc
to correctly declare that callback receives
!chrome.fileManagerPrivate.TaskResult.  I'm not sure why closure
compiled previously without this fix.

Bug:  878324 
Change-Id: Idfe0728cd817ba406b0dd1a1eb80c561944f1ce6
Reviewed-on: https://chromium-review.googlesource.com/c/1290581
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602256}
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/app/file_manager_strings.grdp
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/common/extensions/api/file_manager_private_internal.idl
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/test/crostini_tasks.js
[modify] https://crrev.com/b8aca8932147701179a70ae362fb2285b13ebd53/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7606b46e221578f78378846ce154e91053d4034c

commit 7606b46e221578f78378846ce154e91053d4034c
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 07:00:21 2018

CrOS FilesApp: Change fmp.sharePathWithCrostini to take array of paths

chrome.fileManagerPrivate.sharePathWithCrostini changed name to
chrome.fileManagerPrivate.sharePathsWithCrostini and takes array
of Entry in order to simplify case where multiple paths are
being shared at a single time.

Requires a custom barrier closure in CrostiniSharePath to capture
the first instance of an error and respond with it when done.

Bug:  878324 
Change-Id: I1f308028abda9db92990cc73ad8d7598aee118fe
Reviewed-on: https://chromium-review.googlesource.com/c/1293094
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602267}
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/common/extensions/api/file_manager_private_internal.idl
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/test/crostini_tasks.js
[modify] https://crrev.com/7606b46e221578f78378846ce154e91053d4034c/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

Project Member

Comment 88 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac476a6ee4c10885bf21705a21705d8b05fc8d4a

commit ac476a6ee4c10885bf21705a21705d8b05fc8d4a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 10:26:22 2018

CrOS FilesApp: Share from DriveFS with crostini container.

Depends on
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287389
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287390

Bug:  878324 
Bug:  890649 
Change-Id: I20b57cc7900727fa15ef2de12d247052dd040bff
Reviewed-on: https://chromium-review.googlesource.com/c/1288095
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602288}
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.h
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 89 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9d0058fdd31507faae72dbf3ad1c42f9f39e717d

commit 9d0058fdd31507faae72dbf3ad1c42f9f39e717d
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 20:03:13 2018

vm_tools: seneschal: Support sharing for drivefs

Updated seneschal.conf to mount /media in addition to /home.

Added MEDIA storage_location to support drivefs and removable media.

DriveFS allows paths at /media/fuse/drivefs-<drivefshash> and maps
paths into the container as:
<drivefs>/root/       => /ChromeOS/Google Drive/My Drive
<drivefs>/team_drives => /ChromeOS/Google Drive/Team Drives
<drivefs>/Computers   => /ChromeOS/Google Drive/Computers

Removable maps paths directly from /media/removable to
/ChromeOS/removable.

CQ-DEPEND=CL:1287389
BUG= chromium:878324 
BUG= chromium:890649 
TEST=Install on device, test sharing with FilesApp

Change-Id: I58445de317392e4b03b6e29fc502ca8c31f18b8b
Reviewed-on: https://chromium-review.googlesource.com/1287390
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9d0058fdd31507faae72dbf3ad1c42f9f39e717d/vm_tools/seneschal/service.cc
[modify] https://crrev.com/9d0058fdd31507faae72dbf3ad1c42f9f39e717d/vm_tools/init/seneschal.conf

Project Member

Comment 90 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4f1cbe0a2861957f66833c1b198f75b1a7bcaee3

commit 4f1cbe0a2861957f66833c1b198f75b1a7bcaee3
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 20:03:17 2018

vm_tools: concierge: send seneschal handle when vm already started

BUG= chromium:878324 
TEST=Test sharing with FilesApp

Change-Id: Id3c0cc42db98cb4416a25ec18009c811120ace19
Reviewed-on: https://chromium-review.googlesource.com/1296409
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/4f1cbe0a2861957f66833c1b198f75b1a7bcaee3/vm_tools/concierge/service.cc

Project Member

Comment 91 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e478d0e0545f4a71b2fc5ff4543c831fdb7e59d6

commit e478d0e0545f4a71b2fc5ff4543c831fdb7e59d6
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Oct 25 00:37:40 2018

Share crostini persisted paths in OnStartTerminaVm

Currently SharePersistedPaths is getting called on every invocation
of RestartCrostini. This change will mean that shares are only done
the first time the VM starts.

Bug:  878324 
Change-Id: I72c0c750de71ed9a2d3f3dd91d21fd6991f1eef4
Reviewed-on: https://chromium-review.googlesource.com/c/1297773
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602540}
[modify] https://crrev.com/e478d0e0545f4a71b2fc5ff4543c831fdb7e59d6/chrome/browser/chromeos/crostini/crostini_manager.cc

Project Member

Comment 93 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abe18aa14504a9b5ab1ef49bd3e0db105971d8e9

commit abe18aa14504a9b5ab1ef49bd3e0db105971d8e9
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Oct 26 06:13:59 2018

CrOS FilesApp: Comments and test to disallow sharing DriveFS .Trash with crostini

Bug:  878324 
Change-Id: I2eaec453ff0555b6a77c8dd650a705f8be2d89bd
Reviewed-on: https://chromium-review.googlesource.com/c/1300818
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603000}
[modify] https://crrev.com/abe18aa14504a9b5ab1ef49bd3e0db105971d8e9/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/abe18aa14504a9b5ab1ef49bd3e0db105971d8e9/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Project Member

Comment 94 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/376781fd4022b7f1e8d221e2a789eb722b57b2b7

commit 376781fd4022b7f1e8d221e2a789eb722b57b2b7
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Oct 26 06:16:13 2018

CrOS FilesApp:  Allow share drive computer volumes with crostini

We currently have COMPUTERS_GRAND_ROOT as a sharable volume, but
once you drill into a specific Drive Computer, the volume is COMPUTER.

Bug:  878324 
Change-Id: I25a4bf377200b37c9e5914ad558a3596484f4915
Reviewed-on: https://chromium-review.googlesource.com/c/1300354
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603004}
[modify] https://crrev.com/376781fd4022b7f1e8d221e2a789eb722b57b2b7/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/376781fd4022b7f1e8d221e2a789eb722b57b2b7/ui/file_manager/file_manager/foreground/js/crostini_unittest.js

Project Member

Comment 95 by bugdroid1@chromium.org, Oct 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2559c39611db42e9e4ef6c73a9acc696e53124d8

commit 2559c39611db42e9e4ef6c73a9acc696e53124d8
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Oct 27 00:18:59 2018

vm_tools: seneschal: Add comment that DriveFs .Trash must not be shared

BUG= chromium:878324 
TEST=n/a
Change-Id: I53bba49ccdcf61ec24c741bff83f0af7cc05330c
Reviewed-on: https://chromium-review.googlesource.com/1300933
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/2559c39611db42e9e4ef6c73a9acc696e53124d8/system_api/dbus/seneschal/seneschal_service.proto
[modify] https://crrev.com/2559c39611db42e9e4ef6c73a9acc696e53124d8/vm_tools/seneschal/service.cc

Project Member

Comment 96 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e58032c7960fdd40ce5b2107761e78ab31bf474

commit 2e58032c7960fdd40ce5b2107761e78ab31bf474
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Oct 29 05:04:37 2018

CrOS FilesApp: allow install deb by sharing with crostini

Currently deb files can only be installed into the crostini
container in FilesApp if they are already in Linux files.

Now, files will be shared with the container if they are in
a sharable volume such as Downloads or Drive, so deb files
at these locations can be installed.

Bug:  878324 
Change-Id: I126568eefec1506a205035d9f8a585548f92b527
Reviewed-on: https://chromium-review.googlesource.com/c/1301133
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603415}
[modify] https://crrev.com/2e58032c7960fdd40ce5b2107761e78ab31bf474/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/2e58032c7960fdd40ce5b2107761e78ab31bf474/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/2e58032c7960fdd40ce5b2107761e78ab31bf474/ui/file_manager/file_manager/foreground/js/file_tasks.js

Project Member

Comment 97 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330ec9cfc28b0afc1c82f9106826c6bdee173ecd

commit 330ec9cfc28b0afc1c82f9106826c6bdee173ecd
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Oct 29 06:40:05 2018

webui: Hide menu separators when all items below it until the next separator are hidden

Bug:  878324 
Change-Id: I449362cec69c11182f9d13cdbd4b40410e3b027f
Reviewed-on: https://chromium-review.googlesource.com/c/1304178
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603425}
[modify] https://crrev.com/330ec9cfc28b0afc1c82f9106826c6bdee173ecd/ui/webui/resources/js/cr/ui/menu.js

Project Member

Comment 98 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/918c5c99b7717dfc71617b38f2ea832472da63c7

commit 918c5c99b7717dfc71617b38f2ea832472da63c7
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 30 06:56:17 2018

CrOS FilesApp: Allow sharing of root of volume with crostini

Added 'share-with-linux' command to roots-context-menu and
directory-tree-context-menu so that root volumes can have
right-click > 'Share with Linux'.

Split valid root types out to have DriveFS as a separate
list so that they can be controlled with the DriveFS
feature flag.

Bug:  878324 
Change-Id: Icbcd8f8fd709c8ccfd9cf87f902779731c8923e4
Reviewed-on: https://chromium-review.googlesource.com/c/1304042
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603811}
[modify] https://crrev.com/918c5c99b7717dfc71617b38f2ea832472da63c7/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/918c5c99b7717dfc71617b38f2ea832472da63c7/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/918c5c99b7717dfc71617b38f2ea832472da63c7/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/918c5c99b7717dfc71617b38f2ea832472da63c7/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/918c5c99b7717dfc71617b38f2ea832472da63c7/ui/file_manager/file_manager/test/js/test_util.js

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85cc78014e0a0bdc4fde52736347d8204904281d

commit 85cc78014e0a0bdc4fde52736347d8204904281d
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 30 08:18:10 2018

Restart crostini if required before sharing paths

Updated tests a little to use constant values rather than
true/false to make tests clearer.

Removed unneeded calls to SetChromeOSVersionInfoForTest

Bug:  878324 
Change-Id: Ic8d41ff75084c6e3c037283e26f434c426167816
Reviewed-on: https://chromium-review.googlesource.com/c/1304273
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603833}
[modify] https://crrev.com/85cc78014e0a0bdc4fde52736347d8204904281d/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/85cc78014e0a0bdc4fde52736347d8204904281d/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Project Member

Comment 100 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09a1ec400631d7ea053a52b61ed9c13d04c8e963

commit 09a1ec400631d7ea053a52b61ed9c13d04c8e963
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 01 00:41:02 2018

Collapse crostini shared paths when a parent is shared.

If 2 child dirs such as /a/a, and /a/b, are shared, then parent
/a is shared, we no longer register both children as being shared
and we only show the parent in settings page as being shared.
If the parent is subsequently unshared, then children will also be
unshared.

Bug:  878324 
Change-Id: I1c85d75ad934d48cd353299943f7de893ca62017
Reviewed-on: https://chromium-review.googlesource.com/c/1306945
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604465}
[modify] https://crrev.com/09a1ec400631d7ea053a52b61ed9c13d04c8e963/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/09a1ec400631d7ea053a52b61ed9c13d04c8e963/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/09a1ec400631d7ea053a52b61ed9c13d04c8e963/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/09a1ec400631d7ea053a52b61ed9c13d04c8e963/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/09a1ec400631d7ea053a52b61ed9c13d04c8e963/ui/file_manager/file_manager/foreground/js/crostini_unittest.js

Project Member

Comment 101 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ff61be58062c82dc2dcbe2e3b6486499057af3

commit 09ff61be58062c82dc2dcbe2e3b6486499057af3
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 01 05:54:36 2018

Map correct My files path for crostini path sharing

Map paths into the container as /mnt/chromeos/MyFiles/Downloads
rather than /mnt/chromeos/Downloads to prepare for coming changes
with MyFiles.

Made all crostini mappings to use CamelCase for dir names.

Bug:  878324 
Change-Id: I7c1635dab406242d43d95ee7d44730ee11f6758f
Reviewed-on: https://chromium-review.googlesource.com/c/1309555
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604526}
[modify] https://crrev.com/09ff61be58062c82dc2dcbe2e3b6486499057af3/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/09ff61be58062c82dc2dcbe2e3b6486499057af3/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/09ff61be58062c82dc2dcbe2e3b6486499057af3/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/09ff61be58062c82dc2dcbe2e3b6486499057af3/chrome/browser/chromeos/fileapi/file_system_backend.h

Project Member

Comment 102 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3d2e169ea92ef5a5a81233ba6bedfaa8c0ed8b6c

commit 3d2e169ea92ef5a5a81233ba6bedfaa8c0ed8b6c
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Nov 07 14:34:23 2018

vm_tools: seneschal: Add support for MY_FILES, use CamelCase mappings

CrOS files are changing soon where <cryptohome>/Downloads
is being replaced by <cryptohome>/MyFiles and downloads dir
will be <crypthome>/MyFiles/Downloads.

In advance of this change, seneschal is being modified to
map /Downloads to /mnt/chromeos/My files/Downloads rather than
/mnt/chromeos/Downloads to reduce future disruption.

Changed mapped paths to use CamelCase and avoid spaces.

BUG= chromium:878324 
TEST=Install on device, test sharing with FilesApp

Change-Id: I4749a3a67da555fa3d152a9a8ad51cbc42208ba1
Reviewed-on: https://chromium-review.googlesource.com/1309514
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/3d2e169ea92ef5a5a81233ba6bedfaa8c0ed8b6c/system_api/dbus/seneschal/seneschal_service.proto
[modify] https://crrev.com/3d2e169ea92ef5a5a81233ba6bedfaa8c0ed8b6c/vm_tools/seneschal/service.cc

Project Member

Comment 103 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4453e28d517430587e0b2e77218a11278153039

commit c4453e28d517430587e0b2e77218a11278153039
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 08 01:03:55 2018

Suport MyFiles for crostini path sharing

Bug:  878324 
Change-Id: I09976b84a4016d687c505f0808d92d57ab87ee7c
Reviewed-on: https://chromium-review.googlesource.com/c/1312138
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606262}
[modify] https://crrev.com/c4453e28d517430587e0b2e77218a11278153039/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/c4453e28d517430587e0b2e77218a11278153039/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Project Member

Comment 104 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16

commit 5dc76e988fb40ac1a1b71a423317e1dceb4f2d16
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Nov 13 22:44:39 2018

CrOS FilesApp: New event for crostini shared paths changing

Added a new chrome.fileManagerPrivate.onCrostiniSharedPathsChanged
function which receives type CrostiniSharedPathsChangedEvent.

Changed CrostiniSharePath to be a keyed service class since it now
holds state in the form of an ObserverList to receive unshare events.

file_manager::EventRouter registers as an observer for UnsharePath
events and propogates them to FilesApp.

crostiniShare.testSharePathsCrostiniSuccess simulates an unshare event
and verifies that it is handled correctly and a folder which is
unshared can subsequently be shared again.

Bug:  878324 
Change-Id: I15ee3d75038f3bb3e127bd4f3effc3829a1854db
Reviewed-on: https://chromium-review.googlesource.com/c/1329816
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607778}
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_share_path.h
[add] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_share_path_factory.cc
[add] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_share_path_factory.h
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/extensions/file_manager/event_router.h
[add] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/extensions/file_manager/event_router_unittest.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/browser/ui/webui/settings/chromeos/crostini_handler.cc
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/5dc76e988fb40ac1a1b71a423317e1dceb4f2d16/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

Project Member

Comment 105 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42bc74be565924fb42ada9af875798ddeebaa524

commit 42bc74be565924fb42ada9af875798ddeebaa524
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Nov 14 04:45:17 2018

Only add new crostini shared path to prefs if it does not already exist.

Bug:  878324 
Change-Id: I2d738bb3f980d200b946f0b6cf7522b830f4d5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1334669
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607908}
[modify] https://crrev.com/42bc74be565924fb42ada9af875798ddeebaa524/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/42bc74be565924fb42ada9af875798ddeebaa524/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e17bee9c2e5139fb675d08e3527a6e138f3fe4

commit 78e17bee9c2e5139fb675d08e3527a6e138f3fe4
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Nov 14 06:11:41 2018

Set crostini-files flag on by default

Bug:  878324 
Change-Id: I7f14a0734ea2371215d41a2df7e4b3d0255afde6
Reviewed-on: https://chromium-review.googlesource.com/c/1334670
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607918}
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/about_flags.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chromeos/chromeos_features.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chromeos/chromeos_features.h
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chromeos/chromeos_switches.cc
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chromeos/chromeos_switches.h
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js
[modify] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/ui/file_manager/file_manager/test/js/strings.js

Project Member

Comment 107 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85

commit bde2b01f89501bc654932d2dabe8a3c1ac0dbb85
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 15 05:24:00 2018

FilesApp crostini: show dialog when sharing root folders

When a user right-clicks and shares a root folder of a volume,
a dialog is shown for the user to confirm the action.

For Drive, the dialog with specific wording for Drive is shown
for My Drive, Team Drives, and Computers.

For other volumes, generic wording is used.

Bug:  878324 
Change-Id: I92dad87c8e7b042dd45902d93e08e3cd66abc753
Reviewed-on: https://chromium-review.googlesource.com/c/1337109
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608269}
[modify] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI.png.sha1
[add] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI_DRIVE.png.sha1
[add] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI_TITLE.png.sha1
[modify] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/ui/file_manager/file_manager/test/crostini_share.js

Project Member

Comment 108 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c32ec95c67f2a496c83c81613437b6dc32d7966

commit 2c32ec95c67f2a496c83c81613437b6dc32d7966
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 15 05:30:27 2018

vm_tools: seneschal: Add support for Unshare

Unmounts and deletes specified path from /mnt/chromeos.
Fails if mount does not exist in /proc/self/mounts, or
if a parent path is also mounted.
Unmounts and removes any children mounted paths.

BUG= chromium:878324 
TEST=Install on device, test with FilesApp/settings

Change-Id: I3a0ff8547f64f120439b38447f7851e357a80eb4
Reviewed-on: https://chromium-review.googlesource.com/1317278
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/2c32ec95c67f2a496c83c81613437b6dc32d7966/vm_tools/seneschal/client.cc
[modify] https://crrev.com/2c32ec95c67f2a496c83c81613437b6dc32d7966/vm_tools/seneschal/service.cc
[modify] https://crrev.com/2c32ec95c67f2a496c83c81613437b6dc32d7966/vm_tools/seneschal/service.h
[modify] https://crrev.com/2c32ec95c67f2a496c83c81613437b6dc32d7966/system_api/dbus/seneschal/seneschal_service.proto
[modify] https://crrev.com/2c32ec95c67f2a496c83c81613437b6dc32d7966/system_api/dbus/seneschal/dbus-constants.h

Project Member

Comment 109 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6925d865869ef6b53108c30cd58d0f43d82e52

commit ca6925d865869ef6b53108c30cd58d0f43d82e52
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 15 05:31:02 2018

Move crostini shared path state into background

Convert Crostini to a class, and move state into bg so that all
FilesApp windows will have a consistent view of which paths are shared.

Bug:  878324 
Change-Id: I3c21465b625091fd6360e6b799d9e85baf1ea614
Reviewed-on: https://chromium-review.googlesource.com/c/1335747
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608270}
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[add] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/externs/background/crostini.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/externs/background/file_browser_background_full.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/externs/command_handler_deps.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/background/js/background.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/background/js/background_scripts.js
[add] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/background/js/crostini.js
[add] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/background/js/crostini_unittest.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/ui/file_manager/file_manager/foreground/js/crostini.js
[delete] https://crrev.com/bde2b01f89501bc654932d2dabe8a3c1ac0dbb85/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/ca6925d865869ef6b53108c30cd58d0f43d82e52/ui/file_manager/file_manager/test/js/externs.js

Project Member

Comment 111 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4152f16575ba6ce5763d87bd2412a6c8233b0c9

commit c4152f16575ba6ce5763d87bd2412a6c8233b0c9
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Nov 16 01:57:51 2018

FilesApp: show toast after sharing folder with crostini

Bug:  878324 
Change-Id: I2f1448019648c70329d991485b31b7e0ccc4bde1
Reviewed-on: https://chromium-review.googlesource.com/c/1337147
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608628}
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_FOLDER_SHARED_WITH_CROSTINI.png.sha1
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/foreground/elements/elements_bundle.html
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/c4152f16575ba6ce5763d87bd2412a6c8233b0c9/ui/file_manager/file_manager/test/scripts/create_test_main.py

Project Member

Comment 112 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c7f43c7acd620a31385acde7ad242236861616

commit 67c7f43c7acd620a31385acde7ad242236861616
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Nov 26 23:24:57 2018

Fix bug in ExtractMountNameAndFullPath to set volume root as "/"

Bug found coding/testing
https://chromium-review.googlesource.com/c/chromium/src/+/1350375

Bug:  878324 
Change-Id: I800bf263f17370d43c7b8413cd6af9cd819bfd0c
Reviewed-on: https://chromium-review.googlesource.com/c/1350421
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610972}
[modify] https://crrev.com/67c7f43c7acd620a31385acde7ad242236861616/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/67c7f43c7acd620a31385acde7ad242236861616/chrome/browser/chromeos/file_manager/path_util_unittest.cc

Project Member

Comment 113 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/620e9b7369aeb16f73a5321968fcb5c20f597106

commit 620e9b7369aeb16f73a5321968fcb5c20f597106
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Nov 27 02:44:18 2018

FilesApp crostini shared folder: show toast on startup

The first time when FilesApp is started in a session, it should
show a toast displaying the number of folders currently
shared with crostini, and a link to manage sharing.

* Added state to crostini::CrostiniSharePath keyed profile service
for whether the GetPersistedSharedPaths function has been called
in a session.

* Change FileManagerPrivateInternalGetCrostiniSharedPathsFunction
to call file_manager::util::ExtractMountNameAndFullPath which allows
Entry to be set sync rather than async via
file_manager::util::ConvertFileDefinitionListToEntryDefinitionList

* Changed CommandHandler.recordMenuItemSelected to be public to
allow us to record UMA when user selects 'Manage sharing' in the
startup toast.

Bug:  878324 
Change-Id: I283eb49b61bafdde414a7d1b7aa0723997687742
Reviewed-on: https://chromium-review.googlesource.com/c/1350375
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610999}
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_FOLDER_SHARED_WITH_CROSTINI_PLURAL.png.sha1
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/common/extensions/api/file_manager_private_internal.idl
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

Do you want anecdotal data posted here regarding things that don't work (and stuff that does) when trying to use the sd card from linux apps, or is it premature?
It would be great to hear of any issues.  Feel free to open new bugs, or comment here.
ok,
here's one that is either a permission issue, or illustrates that I misunderstand something about rsync.

rsync creates an error when you try to create a log file on the sd card.  If the log file already exists, it will append to it.  If the log file doesn't exist, you get a permission error.  Note that rsync will create files for the sync part of the operation, just not a log file.

Here's an example of an rsync that works to copy files, but also creates an error in regard to the log file:
  rsync -rtogvO --progress \
  --log-file=/mnt/chromeos/removable/<SDcard>/testfolder/testlog.txt \ 
  /home/<username>/testfolder/ \
  /mnt/chromeos/removable/<SDcard>/testfolder/

Here is the error:
  sync: failed to open log-file /mnt/chromeos/removable/<SDcard>/testlog.txt: 
  Invalid argument (22)
    Ignoring "log file" setting.


Which particular folder did you share in this case?  Is it visible at chrome://settings/crostini/sharedPaths?

It looks like you might have shared the 'testfolder' in <SDcard>, and rsync is trying to access a file in the root of the sdcard which is not accessible?
No, I shared the sd card root.  Attached is a screenshot of my sharedpaths

What's happening is that rsync will create the files it needs to do the sync on the "share with linux" folders.  It will create the log file in the linux user's home folder as the destination (/home/<user>).  It just can't create the log-file in one of the "share with linux" folders.  
Screenshot 2018-12-02 at 21.59.30.png
18.2 KB View Download
Here's a screenshot showing the rsync command causing an error trying to create the log-file.
Next the touch command manually creates the log-file.
Then the same rsync command will work and append log data to the file that now exists,

Screenshot 2018-12-02 at 22.35.55.png
97.6 KB View Download
It seems like this might have something in common with the inability to create a trash folder.  see issue 906965  https://bugs.chromium.org/p/chromium/issues/detail?id=906965
I have created  crbug.com/911288  to track the rsync logfile failure.
One issue that I've run into is if I share a folder on a removable device (like a USB connected SSD), if I start crostini while the device isn't plugged in the folder doesn't get shared. I can't figure out how to add those devices from termina using lxc commands either since those seem to operate on the assumption I'm sharing a folder in Downloads. Ideally I'd like those folders to show up when I plug in the device, either automatically or somehow being able to force a refresh without restarting the container.
Ah, one other thing is that if I mv a file from crostini to the shared folder, I'll see messages about insufficient permissions but it will still work. Further changes after the file already exists in the shared folder don't raise any permission complaints.
You would be able to share the removable device by unsharing in the settings page, then sharing again via FilesApp, or restarting the vm.  You are correct that 'vmc share' only supports Downloads.  Support for detecting new mounts in the system after the vm has started and then sharing those mounts can be tracked in  issue 908289 .

I have created issue 912599 to track #c123, but this is expected since we don't allow chmod operations on shared folders.
I have another example of permissions stuff in regard to crostini and sd cards I can document for you.
I will point out at the outset that both of my devices are still on 72.0.3609.3.  For some reason coral and fizz have not yet rolled to 72.0.3623.3.

Here's the data.  On my coral device (Lenovo 500e), read/write/execute access is all turned on.
On my fizz device (HP Chromebox G2) write access is off.  
See the attached screenshots for each.
Also note that even though these are both default crostini setups, they display differently.  I have not altered any environment/shell settings - note the color differences.

Hope this is helpful.
sd card file permissions, 500e.png
166 KB View Download
sd card file permissions, g2.png
271 KB View Download

Comment 126 Deleted

Turns out the color difference is actually BECAUSE of the permissions difference.  The bash setup in crostini gives "other-writable" folders a green background.

So the only thing to figure out is why coral has user, group and other folders as writable and fizz has none of them as writable.
Project Member

Comment 128 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/895a9fd9a72252620e7d5821f5d8025da180d620

commit 895a9fd9a72252620e7d5821f5d8025da180d620
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Dec 07 06:06:52 2018

vm_tools: seneschal: Access android files in crostini

Updated seneschal startup config to:
* bind mount /run/arc/sdcard and create if required
* map user and group android-root (655360)
* map group android-everybody (665357)

Updated seneschal service.  added new
StorageLocation type PLAY_FILES to
allow the container to access android files.

BUG= chromium:878324 
TEST=Install on device, test sharing with FilesApp

Change-Id: Ib33e6d929c59cce44320cd87b99024fb8e2d3266
Reviewed-on: https://chromium-review.googlesource.com/1338781
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/895a9fd9a72252620e7d5821f5d8025da180d620/vm_tools/seneschal/client.cc
[modify] https://crrev.com/895a9fd9a72252620e7d5821f5d8025da180d620/vm_tools/seneschal/service.cc
[modify] https://crrev.com/895a9fd9a72252620e7d5821f5d8025da180d620/system_api/dbus/seneschal/seneschal_service.proto
[modify] https://crrev.com/895a9fd9a72252620e7d5821f5d8025da180d620/vm_tools/init/seneschal.conf

Project Member

Comment 129 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8ea0dce1894371da7ce9965615326d945cb6e8af

commit 8ea0dce1894371da7ce9965615326d945cb6e8af
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Dec 08 16:43:59 2018

group_baseline: add seneschal to android-everybody

User seneschal requires membership in android-everybody in order
to share android files at /run/arc/sdcard/write/emulated/0
with the crostini vm.

BUG= chromium:878324 
TEST=trybot
CQ-DEPEND=CL:1351170

Change-Id: I0bc8e351a5169d74f33eb845ffe8357b5c7cc18e
Reviewed-on: https://chromium-review.googlesource.com/1363612
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8ea0dce1894371da7ce9965615326d945cb6e8af/cros/test/usergroup_baseline.py

Project Member

Comment 130 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/5b3fe5b024908c91298c45c7e014d4fa89abc2ff

commit 5b3fe5b024908c91298c45c7e014d4fa89abc2ff
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Dec 08 16:43:58 2018

Add seneschal user to android-everybody group

User seneschal allows the crostini container to access
files from the host by bind mounting various directories
into a directory served by the 9p fileserver.  This change
allows the crostini container to access Android files.

BUG= chromium:878324 
TEST=Install on device, test sharing with FilesApp
CQ-DEPEND=CL:1363612

Change-Id: If5a46e9aab706c2c94f2e5dfbc0809b7dd25db80
Reviewed-on: https://chromium-review.googlesource.com/1351170
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5b3fe5b024908c91298c45c7e014d4fa89abc2ff/profiles/base/accounts/group/android-everybody

Blockedon: 914616
Project Member

Comment 133 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/6832c25a9cbd34a2a475206cda53e2e8c9fa9081

commit 6832c25a9cbd34a2a475206cda53e2e8c9fa9081
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 03 23:04:36 2019

tremplin: Create android-root user android-everybody group

BUG= chromium:878324 
TEST=Install on device, test sharing with FilesApp

Change-Id: I76f61fe02d0d0d6027b8b2eccb21fafce133a664
Reviewed-on: https://chromium-review.googlesource.com/1351172
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/6832c25a9cbd34a2a475206cda53e2e8c9fa9081/src/chromiumos/tremplin/main.go
[modify] https://crrev.com/6832c25a9cbd34a2a475206cda53e2e8c9fa9081/src/chromiumos/tremplin/tremplin.go

Status: Fixed (was: Assigned)
Showing comments 35 - 134 of 134 Older

Sign in to add a comment