New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878321 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Sep 12
Cc:
mlippautz@chromium.org
█ hpayer@chromium.org
haraken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 754104
Blocking:
issue 843903



Sign in to add a comment

Blink bot for unified heap garbage collection

Project Member Reported by mlippautz@chromium.org, Aug 28 
We'd like to request a bot for the new unified heap garbage collection, similar to  issue 817779  and  issue 812533 .

Waterfall: chromium.fyi
Configuration: Off the shelf Linux64 release w/ DCHECK (layout tests, unit tests, etc)
Blink runtime flag: HeapUnifiedGarbagecollection [1]

CI is good enough, if there's resources to add an FYI on CQ too that would be awesome.

[1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/runtime_enabled_features.json5?q=runtime-enabled-features&sq=package:chromium&dr=C&l=537

Comment 1 by jbudorick@chromium.org, Aug 28

Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jbudorick@chromium.org, Aug 28 

Note that release w/ DCHECK is primarily a compromise configuration for try bots; CI bots typically do not override the DCHECK settings of their build configuration (i.e. debug builds typically have DCHECKs on, release builds typically don't).

Are you sure you want release+DCHECKs on CI?
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e1e1f1cf15fde3b8cf0aaba2d46508c232f3b6af

commit e1e1f1cf15fde3b8cf0aaba2d46508c232f3b6af
Author: John Budorick <jbudorick@google.com>
Date: Tue Aug 28 23:35:36 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4492fdb584c7611229c3455d8fbb3ab895e28c0f

commit 4492fdb584c7611229c3455d8fbb3ab895e28c0f
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Aug 28 23:46:46 2018

Add recipe config for linux-blink-heap-unified-gc.

Bug:  878321 
Change-Id: I400ac6f6c30db9f84d0b91df0f528f323c07ee31
Reviewed-on: https://chromium-review.googlesource.com/1194596
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.expected/linux_builder.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_bisect.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_affected_targets_only.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_using_bisect.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/first_revision_of_entire_range_failed_but_is_not_culprit.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_directory_does_not_exist.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_not_bisect.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded_non_json_buildbucket.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_error_code.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/no_change.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/script_error.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.expected/basic.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux_new.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_affected_files.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_recipes.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/4492fdb584c7611229c3455d8fbb3ab895e28c0f/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

Comment 5 by mlippautz@chromium.org, Aug 29 

#2: Sorry, I thought that's the easiest. 

I think we want DCHECKs, so a regular Linux debug build then for CI.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9663b430bdf92cca9888a549f38b862cca285ef8

commit 9663b430bdf92cca9888a549f38b862cca285ef8
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Aug 29 21:39:35 2018

Revert "Add recipe config for linux-blink-heap-unified-gc."

This reverts commit 4492fdb584c7611229c3455d8fbb3ab895e28c0f.

Reason for revert: Linux Builder did not like this.

Original change's description:
> Add recipe config for linux-blink-heap-unified-gc.
> 
> Bug:  878321 
> Change-Id: I400ac6f6c30db9f84d0b91df0f528f323c07ee31
> Reviewed-on: https://chromium-review.googlesource.com/1194596
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>

TBR=sergeyberezin@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: I8da07132ad0587330f2e513dbf85bbd58a5f9fc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  878321 
Reviewed-on: https://chromium-review.googlesource.com/1195906
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.expected/linux_builder.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_bisect.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_affected_targets_only.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_using_bisect.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/first_revision_of_entire_range_failed_but_is_not_culprit.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_directory_does_not_exist.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_not_bisect.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded_non_json_buildbucket.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_error_code.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/no_change.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/script_error.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.expected/basic.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux_new.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_affected_files.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_recipes.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/9663b430bdf92cca9888a549f38b862cca285ef8/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab10871a15193627ac1319ac1dc053ffeec774cc

commit ab10871a15193627ac1319ac1dc053ffeec774cc
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Sep 01 00:12:21 2018

Add luci & test configs for linux-blink-heap-unified-gc.

This also rewrites some of the args logic in generate_buildbot_json.py
and allows for callers to supply additional keys containing args they'd
like to pull in (e.g. "gtest_args" for args that should apply only to
gtests).

Bug:  878321 
Change-Id: I2314c90d5959f3cfdaa3898a2de1af2331d07002
Reviewed-on: https://chromium-review.googlesource.com/1197407
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588219}
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/ab10871a15193627ac1319ac1dc053ffeec774cc/testing/buildbot/waterfalls.pyl
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5fac9357d5c57c706ba0ce7b602ba49f79af9f25

commit 5fac9357d5c57c706ba0ce7b602ba49f79af9f25
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Sep 04 15:27:15 2018

Add recipe config for linux-blink-heap-unified-gc. (RELAND)

Bug:  878321 
Change-Id: I7370deaec5a16e115d49634ca259d9d0ff91d658
Reviewed-on: https://chromium-review.googlesource.com/1197067
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/5fac9357d5c57c706ba0ce7b602ba49f79af9f25/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5fac9357d5c57c706ba0ce7b602ba49f79af9f25

commit 5fac9357d5c57c706ba0ce7b602ba49f79af9f25
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Sep 04 15:27:15 2018

Add recipe config for linux-blink-heap-unified-gc. (RELAND)

Bug:  878321 
Change-Id: I7370deaec5a16e115d49634ca259d9d0ff91d658
Reviewed-on: https://chromium-review.googlesource.com/1197067
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/5fac9357d5c57c706ba0ce7b602ba49f79af9f25/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5fac9357d5c57c706ba0ce7b602ba49f79af9f25

commit 5fac9357d5c57c706ba0ce7b602ba49f79af9f25
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Sep 04 15:27:15 2018

Add recipe config for linux-blink-heap-unified-gc. (RELAND)

Bug:  878321 
Change-Id: I7370deaec5a16e115d49634ca259d9d0ff91d658
Reviewed-on: https://chromium-review.googlesource.com/1197067
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/5fac9357d5c57c706ba0ce7b602ba49f79af9f25/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Comment 11 by jbudorick@chromium.org, Sep 4 

Bot is up but is having issues due to a mismatch in chromium_tests configuration between the builder and the tester.

Comment 12 by mlippautz@chromium.org, Sep 4 

Cool! This will start working at some point or is there further work needed?

Comment 13 by jbudorick@chromium.org, Sep 4 

Needs a little more work on my end over the next day or two.

Comment 14 by mlippautz@chromium.org, Sep 10 

Ping :)

Comment 15 by jbudorick@chromium.org, Sep 12

Blockedon: 754104
Status: Fixed (was: Assigned)
Sorry, the required work was over in another bug -- had to promote the revised builder->tester transfer logic to prod.

Anyhow, this is working as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-blink-heap-unified-gc/297.

Comment 16 by mlippautz@chromium.org, Sep 13 

Thanks a lot!
►

Sign in to add a comment