Regression: Down Arrow key input hold cause wallpaper overlay to scroll continuously
Reported by
khushal....@etouch.net,
Aug 28
|
||||||||
Issue descriptionChrome Version: 70.0.3534.4 (Official Build) Revision ddfef6cc5ce7547a217eefde728409170be53600-refs/branch-heads/3534@{#11} (32/64-bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/ What steps will reproduce the problem? (1) Launch chrome, open NTP, click on gear icon then select 'Choose background' option ('Select a collection' overlay will open) and select any collection. (2) Now to scroll wallpapers hold the down arrow key and Observe. Actual Result: Down Arrow key input hold cause wallpaper overlay to scroll continuously. Expected Result: Down Arrow key input hold should cause wallpaper overlay scroll till last wallpaper and avoid continuous scroll. This is a Regression issue seen from 'M-70' and providing the bisect info below: Good Build: 70.0.3532.0 (Revision: 585633) Bad Build: 70.0.3533.0 (Revision: 586155) (Unable to provide bisect using per-revision script as "[Errno 2] No such file or directory" error message is thrown, hence providing narrow bisect) You are probably looking for a change made after 585909 (known good), but no later than 585958 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/cedf15c7b4d8b44acefbb183334a1cb59a713965..20126be26f6a30d7abead004e738b11bfce88213 Suspect: r585917 ?? @sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is also seen on M-70 Canary version #70.0.3535.0. Please refer the attached screen-cast. Thank You..!!
,
Aug 28
,
Aug 28
This is related to one of my CL. Right now, the scrollbar movement is according to which tile you focus on. The reason why it will scroll back is because when you hit the last tile, it will go back to the first tile as an endless loop. In the expected video version, the viewpoint is not following the focus of the tile. So even though the viewpoint scroll to the bottom, it still focus on the first tile. Is that what we are expecting?
,
Aug 28
,
Aug 29
,
Aug 29
Update: With respect to comment #3, @sweilun: When we scroll wallpapers using down arrow key, scrollbar and viewpoint should reach to the bottom without following endless loop. Also, the focus should reach last tile of that particular wallpaper column. Thank You..!!
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c08ef6f7e72cf72e378ca36c22d328c3795ba2f1 commit c08ef6f7e72cf72e378ca36c22d328c3795ba2f1 Author: Weilun Shi <sweilun@chromium.org> Date: Thu Aug 30 01:33:26 2018 [NTP] Scrolling down will stop when hitting the bottom tile On custom background dialog, scrolling will stop when there is no more tile available in that direction. Bug: 878318 Change-Id: I75271ba70cb748f652f5013cb5ff0a83cf701561 Reviewed-on: https://chromium-review.googlesource.com/1195712 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#587382} [modify] https://crrev.com/c08ef6f7e72cf72e378ca36c22d328c3795ba2f1/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Aug 30
,
Aug 31
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version #70.0.3538.0 and the issue is found FIXED. Hence, adding the respective labels. Please refer the attached screen-cast. Thank You..!!
,
Aug 31
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ramyan@chromium.org
, Aug 28