[ASan] WidgetTest.WidgetDestroyedItselfDoesNotCrash crashes in ChromeOS |
||
Issue descriptionAfter https://chromium-review.googlesource.com/c/chromium/src/+/1145261/ lands, we should fix native_widget_aura.cc and mac too as WidgetTest.WidgetDestroyedItselfDoesNotCrash crashes with ASan. https://cs.chromium.org/chromium/src/ui/views/widget/native_widget_aura.cc?l=898 and https://cs.chromium.org/chromium/src/ui/views/widget/native_widget_mac.mm?l=120 shall be updated to something similar to: // |OnNativeWidgetDestroyed| may delete |this| if the object does not own // itself. bool should_delete_this = (ownership_ == Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET); native_widget_delegate_->OnNativeWidgetDestroyed(); if (should_delete_this) delete this;
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e34ae84a36ab96282f2c99a801d185606d6faf67 commit e34ae84a36ab96282f2c99a801d185606d6faf67 Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Aug 28 13:44:52 2018 Fix ASan WidgetTest.WidgetDestroyedItselfDoesNotCrash crash. This makes sure WidgetTest.WidgetDestroyedItselfDoesNotCrash test does NOT crash with use-after-free ASan error in ChromeOS and Mac. Test was added in https://chromium-review.googlesource.com/c/chromium/src/+/1145261/ and only covered Windows and Linux. Bug: 878314 Change-Id: Ifde7f402955bd34bfd0618e4f67c52feeb333624 Reviewed-on: https://chromium-review.googlesource.com/1193283 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#586678} [modify] https://crrev.com/e34ae84a36ab96282f2c99a801d185606d6faf67/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/e34ae84a36ab96282f2c99a801d185606d6faf67/ui/views/widget/native_widget_mac.mm
,
Aug 28
|
||
►
Sign in to add a comment |
||
Comment 1 by fbeaufort@chromium.org
, Aug 28