New issue
Advanced search Search tips

Issue 878281 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Throw for disturbed/locked streams more often

Project Member Reported by annevank...@gmail.com, Aug 28

Issue description

In https://github.com/whatwg/fetch/pull/801, tests in https://github.com/web-platform-tests/wpt/pull/12639, the decision was made to throw for more ReadableStream states. It'd be good to align with that.
 
Cc: ricea@chromium.org yhirano@chromium.org
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Windows
Status: Available (was: Unconfirmed)
Setting status to "Available" as yhirano already agreed to the spec change.

Not assigning as I'm not sure who will take this on yet.
I want to work on this issue.
Can I take a look?
#2 You're welcome to.

We don't yet support ReadableStream in many of these APIs, so you may only be able to make the Response constructor change.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4

commit 3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4
Author: Dong-hee Na <donghee.na92@gmail.com>
Date: Wed Sep 19 15:15:39 2018

Fetch: Throw TypeError for response from disturbed/locked streams

If the Response body object is a readable stream then check whether
the object is disturbed or locked.
If the condition is true then throw TypeError.

refernce: https://fetch.spec.whatwg.org/#concept-bodyinit-extract

Bug:  878281 
Change-Id: I0593d048e7bd146863efdc9f1d355bc70857cdc0
Reviewed-on: https://chromium-review.googlesource.com/1226718
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592402}
[delete] https://crrev.com/bc2b383e2edefb3c6c5d99f0cffd2eb5cac26fdb/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any-expected.txt
[delete] https://crrev.com/bc2b383e2edefb3c6c5d99f0cffd2eb5cac26fdb/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.serviceworker-expected.txt
[delete] https://crrev.com/bc2b383e2edefb3c6c5d99f0cffd2eb5cac26fdb/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.sharedworker-expected.txt
[delete] https://crrev.com/bc2b383e2edefb3c6c5d99f0cffd2eb5cac26fdb/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.worker-expected.txt
[modify] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/call-extra-crash-construct-and-look.html
[modify] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/call-extra-crash-is-disturbed.html
[modify] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js
[modify] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/blink/renderer/core/fetch/response.cc

Status: Fixed (was: Available)
Fixed by donghee.na92@gmail.com.

Sign in to add a comment