New issue
Advanced search Search tips

Issue 878278 link

Starred by 1 user
Status: Fixed
Owner:
sa...@chromium.org
Closed: Aug 29
Cc:
noel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

When offline, unavailable files in team drives and shared with me are not greyed out

Project Member Reported by sa...@chromium.org, Aug 28 
Chrome Version: 69.0.3497.35
OS: ChromeOS

What steps will reproduce the problem?
(1) Disconnect from the network
(2) Navigate to a team drive (or folder in a team drive) or shared with me in the files app

What is the expected result?

Files unavailable offline are greyed out

What happens instead?

No files within a team drive or shared with me are greyed out

Comment 1 by sa...@chromium.org, Aug 28

Status: Available (was: Untriaged)
It looks like the css rule for greying out offline files (https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/css/file_manager.css?l=1681&rcl=d88e1be101eac05f7d16c988793338909242c2ba) only applies if body has a drive attribute, which is only set when within the My Drive root (https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/banners.js?l=741&rcl=d88e1be101eac05f7d16c988793338909242c2ba).

Comment 2 by sa...@chromium.org, Aug 28

Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4191c51077e30bbc95db353fba71212d915ccb19

commit 4191c51077e30bbc95db353fba71212d915ccb19
Author: Sam McNally <sammc@chromium.org>
Date: Tue Aug 28 08:00:01 2018

Apply dim-offline, even when the body doesn't have a drive attribute.

This restriction causes files in team drives or shared with me to never
be dimmed in response to being unavailable while offline. Further, files
unaffected by offline-status should never have the dim-offline class set
so this restriction is unnecessary so just remove it.

Bug:  878278 
Change-Id: I0b93dbd125324bfcf9a859f73850801c5c2d0515
Reviewed-on: https://chromium-review.googlesource.com/1192863
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586618}
[modify] https://crrev.com/4191c51077e30bbc95db353fba71212d915ccb19/ui/file_manager/file_manager/foreground/css/file_manager.css

Comment 4 by sa...@chromium.org, Aug 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment