Dialogs show up under the split screen divider |
|||||||||||||
Issue descriptionDialogs should be layered above the divider (and if possible, aligned within their own side of the split, rather than across it). Dialog: https://photos.app.goo.gl/hTaeF1a9tzEEe9LfA Copy/paste tooltips behind divider: https://drive.google.com/open?id=1WvPHkQHLfIwSsxrAnMRbORhx_qP8yheU
,
Sep 27
,
Sep 28
,
Sep 28
,
Oct 1
This is a P1 for Tablet. Do we have an ETA for this landing?
,
Oct 4
I don't think it's a P1. Mark it as P2 and I'll try to get it into M71 if possible.
,
Oct 10
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3acb7ba6a2b6565656736f3050bfc593baf4781 commit c3acb7ba6a2b6565656736f3050bfc593baf4781 Author: Xiaoqian Dai <xdai@chromium.org> Date: Thu Oct 11 17:42:23 2018 splitscreen: Adjust bubble dialog bounds if splitscreen is active. When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598827} [modify] https://crrev.com/c3acb7ba6a2b6565656736f3050bfc593baf4781/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/c3acb7ba6a2b6565656736f3050bfc593baf4781/ash/wm/splitview/split_view_divider.cc [modify] https://crrev.com/c3acb7ba6a2b6565656736f3050bfc593baf4781/ash/wm/splitview/split_view_divider.h
,
Oct 11
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e41458e037d2d6eea8297dfee4006848bb6f123a commit e41458e037d2d6eea8297dfee4006848bb6f123a Author: Patti <patricialor@chromium.org> Date: Fri Oct 12 02:14:27 2018 Revert "splitscreen: Adjust bubble dialog bounds if splitscreen is active." This reverts commit c3acb7ba6a2b6565656736f3050bfc593baf4781. Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683 Original change's description: > splitscreen: Adjust bubble dialog bounds if splitscreen is active. > > When a dialog is added to a window that's currently showig in > splitscreen, we should adjust the dialog bounds to show the dialog > aligned within its own side of the split, rather than across the divider > bar. > > Note the divider is still placed on top of the snapped windows and its > transient children if they are placed in default container. > > Bug: 878268 > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 > Reviewed-on: https://chromium-review.googlesource.com/c/1274197 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598827} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I74d78ce0184d2028811872ac633da33ede16f296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878268 , 894683 Reviewed-on: https://chromium-review.googlesource.com/c/1277907 Reviewed-by: Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599069} [modify] https://crrev.com/e41458e037d2d6eea8297dfee4006848bb6f123a/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/e41458e037d2d6eea8297dfee4006848bb6f123a/ash/wm/splitview/split_view_divider.cc [modify] https://crrev.com/e41458e037d2d6eea8297dfee4006848bb6f123a/ash/wm/splitview/split_view_divider.h
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/205c143746dbf1d37c1eb3c8371b512bfbfe9303 commit 205c143746dbf1d37c1eb3c8371b512bfbfe9303 Author: Xiaoqian Dai <xdai@chromium.org> Date: Mon Oct 15 18:41:40 2018 [reland] splitscreen: Adjust bubble dialog bounds if splitscreen is active. When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 TBR=xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598827} Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332 Reviewed-on: https://chromium-review.googlesource.com/c/1280674 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599693} [modify] https://crrev.com/205c143746dbf1d37c1eb3c8371b512bfbfe9303/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/205c143746dbf1d37c1eb3c8371b512bfbfe9303/ash/wm/splitview/split_view_divider.cc [modify] https://crrev.com/205c143746dbf1d37c1eb3c8371b512bfbfe9303/ash/wm/splitview/split_view_divider.h
,
Oct 15
,
Oct 15
Pls apply appropriate OSs label.
,
Oct 15
,
Oct 16
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
Approving merge to M71 Chrome OS.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae005f3ea09101792e34152c88c05a7966af30b2 commit ae005f3ea09101792e34152c88c05a7966af30b2 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Oct 19 04:57:00 2018 [Merge to M71] Adjust bubble dialog bounds if splitscreen is active. When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 TBR=xiyuan@chromium.org (cherry picked from commit 205c143746dbf1d37c1eb3c8371b512bfbfe9303) Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#598827} Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332 Reviewed-on: https://chromium-review.googlesource.com/c/1280674 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599693} Reviewed-on: https://chromium-review.googlesource.com/c/1290270 Cr-Commit-Position: refs/branch-heads/3578@{#150} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ae005f3ea09101792e34152c88c05a7966af30b2/ash/wm/splitview/split_view_controller_unittest.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae005f3ea09101792e34152c88c05a7966af30b2 Commit: ae005f3ea09101792e34152c88c05a7966af30b2 Author: xdai@chromium.org Commiter: xdai@chromium.org Date: 2018-10-19 04:57:00 +0000 UTC [Merge to M71] Adjust bubble dialog bounds if splitscreen is active. When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 TBR=xiyuan@chromium.org (cherry picked from commit 205c143746dbf1d37c1eb3c8371b512bfbfe9303) Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#598827} Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332 Reviewed-on: https://chromium-review.googlesource.com/c/1280674 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599693} Reviewed-on: https://chromium-review.googlesource.com/c/1290270 Cr-Commit-Position: refs/branch-heads/3578@{#150} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by x...@chromium.org
, Sep 6