New issue
Advanced search Search tips

Issue 878260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 836254



Sign in to add a comment

Add automatic offline Drive Files app display test

Project Member Reported by noel@chromium.org, Aug 28

Issue description

No automatic coverage for offline Drive in Files App.  We should add some, given  issue 876973  is one recent example.
 
Blocking: 836254
Render Files App in offline mode, with some files.  Verify the files are displayed correctly ... 
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e7e0812211f2c6f8a2542fad224ad62489f8d2

commit 36e7e0812211f2c6f8a2542fad224ad62489f8d2
Author: Noel Gordon <noel@chromium.org>
Date: Tue Aug 28 05:29:51 2018

Add basic Files App display test for offline Drive

Offline Drive has no test coverage, let's add some.

Start Files App with offline Drive and render test files. Verify that
the files are correctly rendered for the 'offline' Drive state.

 file: hello.txt should be rendered as not available offline (dimmed)
 folder: photos  should be rendered as available offline
 pinned: pinned  should be rendered as available offline

Enabled for DriveFS only, per CL:1189515.

Test: browser_test --gtest_filter="*fileDisplayDriveOffline*"
Bug:  878260 
Change-Id: I589036310e630480f66ac90a123ae1e3e99669ac
Reviewed-on: https://chromium-review.googlesource.com/1192372
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586591}
[modify] https://crrev.com/36e7e0812211f2c6f8a2542fad224ad62489f8d2/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/36e7e0812211f2c6f8a2542fad224ad62489f8d2/ui/file_manager/integration_tests/file_manager/file_display.js

Cc: sa...@chromium.org lucmult@chromium.org
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Also, the elements computed style could be read in previous test, and adding it to the automatic test to confirm...


Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f9ae10daf7fb6558346ea21a9bf5dc4ae0e2850

commit 3f9ae10daf7fb6558346ea21a9bf5dc4ae0e2850
Author: Noel Gordon <noel@chromium.org>
Date: Wed Aug 29 11:12:05 2018

Files App display test for offline Drive should check CSS style

Querying file list elements with .dim-offline class collects the files
that could be rendered with 'offline' style: it does not mean they are
rendered with 'offline' style.

Fix that by requesting .dim-offline elements and their CSS opacity and
checking the opacity has is the expected value for an offline rendered
file list row entry (opacity 0.4 currently).

Test: browser_tests --gtest_filter="*fileDisplayDriveOffline*"
Bug:  878260 
Change-Id: I636f7a6fc4e85d32c77094ed7e72e0244bf30303
Reviewed-on: https://chromium-review.googlesource.com/1193703
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587073}
[modify] https://crrev.com/3f9ae10daf7fb6558346ea21a9bf5dc4ae0e2850/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/322dd6bb78daa0aef506d715067b7978c9412adb

commit 322dd6bb78daa0aef506d715067b7978c9412adb
Author: Noel Gordon <noel@chromium.org>
Date: Thu Aug 30 07:05:02 2018

Files App display test: add online file CSS style tests

When Drive is offline, files that are 'available offline' are rendered
with 'online' CSS style. Verify that those files have the expected CSS
'online' style (opacity 1).

Also add a new Drive 'online' test case to check that all files render
with the CSS 'online' style (opacity 1).

Test: browser_tests --gtest_filter="FileDisplay/FilesApp*"
Bug:  878260 
Change-Id: I2d97a414fc477acce0af877cf490944e4a087cfb
Reviewed-on: https://chromium-review.googlesource.com/1195172
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587467}
[modify] https://crrev.com/322dd6bb78daa0aef506d715067b7978c9412adb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/322dd6bb78daa0aef506d715067b7978c9412adb/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440a2f964b84ba5e177845c2aee00c0a1322fc6e

commit 440a2f964b84ba5e177845c2aee00c0a1322fc6e
Author: Noel Gordon <noel@chromium.org>
Date: Thu Aug 30 11:43:16 2018

File Display test: check the default path too

Check the default |path| by providing it and call checkIfNoErrors() in
its own step (like every one else).

Bug:  878260 
Change-Id: I12850b65da97967a6075cb9a2869eac2b2b48ec7
Reviewed-on: https://chromium-review.googlesource.com/1195308
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587522}
[modify] https://crrev.com/440a2f964b84ba5e177845c2aee00c0a1322fc6e/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/694c37e7b8cebeeac241898a642eff8b214f81e6

commit 694c37e7b8cebeeac241898a642eff8b214f81e6
Author: Sam McNally <sammc@chromium.org>
Date: Tue Sep 04 08:56:31 2018

Test with a hosted doc in fileDisplayDriveOffline too.

Bug:  878260 
Change-Id: I1ed29f22bde587ba0c7b783115e09cfc650d5d1a
Reviewed-on: https://chromium-review.googlesource.com/1203473
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588476}
[modify] https://crrev.com/694c37e7b8cebeeac241898a642eff8b214f81e6/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/694c37e7b8cebeeac241898a642eff8b214f81e6

commit 694c37e7b8cebeeac241898a642eff8b214f81e6
Author: Sam McNally <sammc@chromium.org>
Date: Tue Sep 04 08:56:31 2018

Test with a hosted doc in fileDisplayDriveOffline too.

Bug:  878260 
Change-Id: I1ed29f22bde587ba0c7b783115e09cfc650d5d1a
Reviewed-on: https://chromium-review.googlesource.com/1203473
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588476}
[modify] https://crrev.com/694c37e7b8cebeeac241898a642eff8b214f81e6/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/694c37e7b8cebeeac241898a642eff8b214f81e6

commit 694c37e7b8cebeeac241898a642eff8b214f81e6
Author: Sam McNally <sammc@chromium.org>
Date: Tue Sep 04 08:56:31 2018

Test with a hosted doc in fileDisplayDriveOffline too.

Bug:  878260 
Change-Id: I1ed29f22bde587ba0c7b783115e09cfc650d5d1a
Reviewed-on: https://chromium-review.googlesource.com/1203473
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588476}
[modify] https://crrev.com/694c37e7b8cebeeac241898a642eff8b214f81e6/ui/file_manager/integration_tests/file_manager/file_display.js

Status: Fixed (was: Started)

Sign in to add a comment