New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878233 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Tracker bug for checkpoint logic separation from measurement logger

Project Member Reported by seankao@google.com, Aug 28

Issue description

Current checkpoint logic stores redundant data in different measurement logger subclasses. This tracker bug aims to solve this issue.

Also, checkpoint data need some pre-processing before uploading to dashboard. Letting a checkpoint class take care of this, is a better way than doing it directly in measurement logger class.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2c685db7086b72b066967ce2f1abf049be36d8bd

commit 2c685db7086b72b066967ce2f1abf049be36d8bd
Author: Sean Kao <seankao@google.com>
Date: Mon Sep 03 09:20:44 2018

power_status: add CheckpointLogger class

BUG= chromium:878233 
TEST=none

Change-Id: Ie506fad65e81af192580dfc724ac5cad35da96cc
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1193202
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/2c685db7086b72b066967ce2f1abf049be36d8bd/client/cros/power/power_status.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7645185e652db44e810089d1f9ed8600e895aa53

commit 7645185e652db44e810089d1f9ed8600e895aa53
Author: Sean Kao <seankao@google.com>
Date: Mon Sep 03 09:20:45 2018

CheckpointLogger: Refactor checkpoint usage for tests

BUG= chromium:878233 
TEST=run tests that uses checkpoint function
power_LoadTest, power_Display, etc.

Change-Id: Ic1fba5193a543d05ff2f28f3c30078d4e71ba414
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1193203
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/7645185e652db44e810089d1f9ed8600e895aa53/client/cros/power/power_test.py
[modify] https://crrev.com/7645185e652db44e810089d1f9ed8600e895aa53/client/site_tests/power_LoadTest/power_LoadTest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a1d52c8260750781b45188b6bcc85fcdec1ef163

commit a1d52c8260750781b45188b6bcc85fcdec1ef163
Author: Sean Kao <seankao@google.com>
Date: Mon Sep 03 15:50:38 2018

power_status, power_dashboard: upload relative checkpoint

BUG= chromium:878233 
TEST=run power_LoadTest.fast
check power_log.json in resultsdir

Change-Id: Id432381e4b21619ff5904d13c349a393229c406b
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1193204
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/a1d52c8260750781b45188b6bcc85fcdec1ef163/client/cros/power/power_status.py
[modify] https://crrev.com/a1d52c8260750781b45188b6bcc85fcdec1ef163/client/cros/power/power_dashboard.py

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e8496468d81eddd91a0625599219b6f6635982ae

commit e8496468d81eddd91a0625599219b6f6635982ae
Author: Sean Kao <seankao@google.com>
Date: Wed Sep 05 12:11:53 2018

power_dashboard: Match BigQuery schema field name.

'checkpoint' is changed to 'checkpoint2', since
'checkpoint2' is the field name for checkpoint
data in BigQuery.

BUG= chromium:878233 
TEST=Run power_LoadTest.fast
Check power_log.json in resultsdir: there should be
a checkpoint2 field.

Change-Id: I1cc20b7090f7e837a787bb3ec2966034987094a6
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1205931
Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/e8496468d81eddd91a0625599219b6f6635982ae/client/cros/power/power_dashboard.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/965406270d769b85b85494e506c0a253c2044b30

commit 965406270d769b85b85494e506c0a253c2044b30
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Tue Sep 18 21:04:15 2018

power_dashboard: tag data with checkpoint

BUG= chromium:878233 
TEST=See checkpoint in power dashboard

Change-Id: Ieaa2001377fa5fd750652603fcda55a16ddf3401
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1227379
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/965406270d769b85b85494e506c0a253c2044b30/client/cros/power/power_dashboard.py

Sign in to add a comment