New issue
Advanced search Search tips

Issue 878232 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Ensure UMA metrics during shutdown are recorded

Project Member Reported by jamescook@chromium.org, Aug 28

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1189711 records some metrics during ash::Shell teardown. I'm sure there are other performance metrics we record during shutdown elsewhere.

Chrome's MetricsService outlives ash::Shell.

~BrowserProcessImpl() destroys metrics_services_manager_ (ultimately owns MetricsService)
ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() destroys ash_shell_init_ (owns ash::Shell)

There's also this call in chrome_browser_main.cc:

    browser_process_->metrics_service()->Stop();

https://cs.chromium.org/chromium/src/chrome/browser/chrome_browser_main.cc?type=cs&sq=package:chromium&g=0&l=2108

However, under multi-process-mash we may have a shutdown race. We need to make sure shutdown metrics in ash get recorded, or at least persisted for upload for the next session.

 

Sign in to add a comment