New issue
Advanced search Search tips

Issue 878224 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Templatize VaapiWrapper::SubmitBuffer()

Project Member Reported by andrescj@chromium.org, Aug 28

Issue description

Many SubmitBuffer() calls are similar to:

vaapi_wrapper_->SubmitBuffer(VAEncPictureParameterBufferType,
                             sizeof(pic_param), &pic_param);

A templatized version of SubmitBuffer() would allow us to get rid of the size argument in these cases.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a4864f71d2177d5fb9b3310b9f8a740842f33a8

commit 7a4864f71d2177d5fb9b3310b9f8a740842f33a8
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Tue Aug 28 16:55:15 2018

VaapiWrapper: create a templatized version of SubmitBuffer().

This CL provides a templatized version of VaapiWrapper::SubmitBuffer()
in order to be able to omit the size argument in many of the calls.

The calls that can use the templatized version are fixed. Others are
left as they are because they involve arrays.

Bug:  878224 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic15f95817c47c7fe0e0293c95c5db8bae616cd21
Reviewed-on: https://chromium-review.googlesource.com/1192742
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586748}
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_h264_accelerator.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_jpeg_encoder.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_vp8_accelerator.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_vp9_accelerator.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/7a4864f71d2177d5fb9b3310b9f8a740842f33a8/media/gpu/vaapi/vaapi_wrapper.h

Status: Fixed (was: Started)

Sign in to add a comment