Build error for Blink
Reported by
wangqing...@loongson.cn,
Aug 28
|
||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3189.0 Safari/537.36
Steps to reproduce the problem:
1. fetch lastest chromium
2. build chromium
What is the expected behavior?
What went wrong?
FAILED: obj/third_party/blink/renderer/core/animation/animation_0/animation_time_delta.o
mips64el-linux-gnu-g++ -MMD -MF obj/third_party/blink/renderer/core/animation/animation_0/animation_time_delta.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_MIPS_ARCH_LOONGSON -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DWTF_USE_WEBAUDIO_FFMPEG=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DV8_DEPRECATION_WARNINGS -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Igen/angle -I../../third_party/libjpeg_turbo -I../../v8/include -Igen/v8/include -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -EL -mabi=64 -march=loongson3a -mno-branch-likely -Wa,-march=loongson3a -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fno-builtin-abs -fvisibility=hidden -g0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -DLIBXML_STATIC= -std=gnu++14 -Wno-narrowing -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -c ../../third_party/blink/renderer/core/animation/animation_time_delta.cc -o obj/third_party/blink/renderer/core/animation/animation_0/animation_time_delta.o
In file included from ../../third_party/blink/renderer/core/animation/animation_time_delta.cc:5:0:
../../third_party/blink/renderer/core/animation/animation_time_delta.h: In function ‘constexpr bool blink::operator==(const blink::AnimationTimeDelta&, const blink::AnimationTimeDelta&)’:
../../third_party/blink/renderer/core/animation/animation_time_delta.h:95:24: error: call to non-constexpr function ‘double blink::AnimationTimeDelta::InSecondsF() const’
return lhs.InSecondsF() == rhs.InSecondsF();
~~~~~~~~~~~~~~^~
../../third_party/blink/renderer/core/animation/animation_time_delta.h: In function ‘constexpr bool blink::operator!=(const blink::AnimationTimeDelta&, const blink::AnimationTimeDelta&)’:
../../third_party/blink/renderer/core/animation/animation_time_delta.h:99:24: error: call to non-constexpr function ‘double blink::AnimationTimeDelta::InSecondsF() const’
return lhs.InSecondsF() != rhs.InSecondsF();
~~~~~~~~~~~~~~^~
../../third_party/blink/renderer/core/animation/animation_time_delta.h: In function ‘constexpr bool blink::operator>(const blink::AnimationTimeDelta&, const blink::AnimationTimeDelta&)’:
../../third_party/blink/renderer/core/animation/animation_time_delta.h:103:24: error: call to non-constexpr function ‘double blink::AnimationTimeDelta::InSecondsF() const’
return lhs.InSecondsF() > rhs.InSecondsF();
~~~~~~~~~~~~~~^~
../../third_party/blink/renderer/core/animation/animation_time_delta.h: In function ‘constexpr bool blink::operator>=(const blink::AnimationTimeDelta&, const blink::AnimationTimeDelta&)’:
../../third_party/blink/renderer/core/animation/animation_time_delta.h:107:24: error: call to non-constexpr function ‘double blink::AnimationTimeDelta::InSecondsF() const’
return lhs.InSecondsF() >= rhs.InSecondsF();
~~~~~~~~~~~~~~^~
../../third_party/blink/renderer/core/animation/animation_time_delta.h: In function ‘constexpr bool blink::operator<=(const blink::AnimationTimeDelta&, const blink::AnimationTimeDelta&)’:
../../third_party/blink/renderer/core/animation/animation_time_delta.h:111:24: error: call to non-constexpr function ‘double blink::AnimationTimeDelta::InSecondsF() const’
return lhs.InSecondsF() <= rhs.InSecondsF();
~~~~~~~~~~~~~~^~
[7/4481] CXX obj/third_party/blink/renderer/core/animation/animation_0/css_animations.o
ninja: build stopped: subcommand failed.
Did this work before? N/A
Does this work in other browsers? N/A
Chrome version: 62.0.3189.0 Channel: n/a
OS Version: OS X 10.13.2
Flash Version:
,
Aug 30
Thanks for filing the issue! The issue seems to be related to building of chromium, which is out of scope for us to triage further. Hence adding label "TE-NeedsTriageHelp" and requesting some one from respective team to have a look into this and help in further triaging it.
,
Aug 31
Try updating to tip of tree and recompiling again. List your chromium git revision and GN args.
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87902b3202f81d689dd314c17006ffc907fe12a1 commit 87902b3202f81d689dd314c17006ffc907fe12a1 Author: Wang Qing <wangqing-hf@loongson.cn> Date: Mon Sep 03 02:41:08 2018 Fix build error for blink. This CLs fixed the error of constexpr function call to non-constexpr function. Bug: 878202 Change-Id: I6ad217a687e62a9a384980d852743a56479de3a9 Reviewed-on: https://chromium-review.googlesource.com/1192467 Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#588316} [modify] https://crrev.com/87902b3202f81d689dd314c17006ffc907fe12a1/third_party/blink/renderer/core/animation/animation_time_delta.cc [modify] https://crrev.com/87902b3202f81d689dd314c17006ffc907fe12a1/third_party/blink/renderer/core/animation/animation_time_delta.h
,
Sep 4
,
Sep 14
Issue 879902 has been merged into this issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vamshi.kommuri@chromium.org
, Aug 28