New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878196 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 29
Cc:
ftirelo@chromium.org
█ dsexton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

NVDA no longer reads in autofill field when left/right pressed (regression)

Project Member Reported by aleventhal@chromium.org, Aug 28 
Steps:
1. Load data:text/html,<form><input type="text" name="zzz"><input type="submit"></form> and submit some text for the field
2. Load NVDA
3. Reload the page
4. Type in some characters that cause the autofill to show
5. Press left/right

NVDA should read the characters, but doesn't.

I bisected, and it is caused by http://crrev.com/c/1088764 ( issue 850094 ). Specifically, adding AutofillPopupBaseView::GetAccessibleNodeData() causes the regression.

Author:     Fabio Tirelo <ftirelo@chromium.org>
AuthorDate: 2018-06-07 16:57:01 +0000
Commit:     Commit Bot <commit-bot@chromium.org>
CommitDate: 2018-06-07 16:57:01 +0000

[af] Set accessibility node for new dropdown

The current implementation reads "autofill menu opened" for the old
dropdown, but only "menu opened" for the new dropdown.

Bug:  850094 
Change-Id: I825069866462897116dc179f6418a8f87f1c3467
Reviewed-on: https://chromium-review.googlesource.com/1088764
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565300}
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/857aee041d5ea69a021aa98542ad49018adf4f2c

commit 857aee041d5ea69a021aa98542ad49018adf4f2c
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Wed Aug 29 16:27:42 2018

Return to using kPane so that NVDA arrow text editing echo works again

Using the correct role kMenu actually breaks editing feedback in
textfields. Use the incorrect role for now. If NVDA fixes this we can
return to using the correct role, which would provide better feedback
users about the menu opening. However, this feedback will not be
necessary if the autofill information is provided upon focus, which
is ultimately the best scenario, as the autofill available state is
then provided immediately to the user whether the menu is visible or
not.

This does not affect other supported screen readers, including JAWS,
ChromeVox and VoiceOver.

Bug:  878196 
Change-Id: I91659cc333f434565992f6269f8bd9a917fb8a5a
Reviewed-on: https://chromium-review.googlesource.com/1194256
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587148}
[modify] https://crrev.com/857aee041d5ea69a021aa98542ad49018adf4f2c/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Comment 2 by aleventhal@chromium.org, Aug 29

Status: Fixed (was: Available)

Comment 3 by krajshree@chromium.org, Aug 30

Labels: TE-Verified-M70 TE-Verified-70.0.3537.0
Able to reproduce the issue on win-10 using chrome build without fix.

Verified the fix on Win-10 using latest chrome version #70.0.3537.0 as per the comment #0.
Note: Could not attach the screen cast as the voice did not get record.
Observed that NVDA read the characters on pressing left or right key.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
►

Sign in to add a comment