New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878193 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Regression, VoiceOver announces permission dialogs title twice

Project Member Reported by aleventhal@chromium.org, Aug 28

Issue description

Regression of  issue 748221 :

Steps:
(1) [No longer necessary in recent builds as this is the default now?] -- turn on #secondary-ui-md
(2) Turn on VoiceOver
(3) https://permission.site/ -> padlock -> ensure everything is set to Ask. Reload.
(4) Click Notifications

What is the expected result?
VoiceOver should announce "permission.site wants to"

What happens instead?
VoiceOver announces "permission.site wants to, permission.site wants to"

Assigning to ellyjones@ for triage.
 
Cc: phanindra.mandapaka@chromium.org
Labels: Needs-Feedback Triaged-ET
Tried to reproduce the issue on latest chrome version 70.0.3534.0 using Mac 10.13.6.Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chrome 
2. Enabled Voice Over and Navigated the URL " https://permission.site/ " -> padlock -> changed to Ask and Reloaded. 
As we are observed that voice Over reads the "permission.site wants to" one time only.

NOTE: First time VoiceOver reading " permission.site Window " and second time reading "permission.site wants to"

@Reporter: Could you please check the attached screen cast and please let us know if anything missed from our end.
Thanks.!
878193.mp4
1.8 MB View Download
Labels: OS-Mac
Owner: jamwalla@chromium.org
Status: Assigned (was: Untriaged)
I think this is the same bug as on Windows with Jaws / NVDA, but I don't know if they both have the same cause, hence I'll keep separate for now.
I believe the cause is that the title of the bubble appears both as the accessible title of the dialog object and also as a label inside the dialog itself.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8f4306edf577bde5d5211b63df598dec30f93c

commit 2e8f4306edf577bde5d5211b63df598dec30f93c
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Mon Sep 17 23:08:15 2018

Surface title of permissions dialog to accessibility only once

PermissionBubbleDialogDelegateView effectively set its title twice for
accessibility - once by implementing GetWindowTitle and once by setting
BubbleFrameView::SetTitleView. This caused the title to be spoken twice
when screenreaders announced the alert. It is fixed by giving the title
Label the accessible attribute kIgnored.

Bug:  878193 
Change-Id: I21df2a335e1cb02c6ef1921f7d37d5897507fe31
Reviewed-on: https://chromium-review.googlesource.com/1228975
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591864}
[modify] https://crrev.com/2e8f4306edf577bde5d5211b63df598dec30f93c/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Tried to reproduce the issue on Mac 10.13.6 using reported chrome 70.0.3534.0 and latest chrome 71.0.3556.0.Attaching screen cast for reference.
Steps: 
---------
1. Launched reported chrome 
2. Enabled Voice Over and Navigated the URL " https://permission.site/ " -> padlock -> changed to Ask and Reloaded. 
As we are observed that voice Over reads the "permission.site wants to" one time only.

James Wallace-Lee@ - Could you please check the attached screen cast and please let us know if anything missed from our end. Also help in fixing this issue.

Thanks...!
878193.mp4
2.4 MB View Download
Labels: -Needs-Feedback -Needs-Bisect TE-Verified-71.0.3556.0 TE-Verified-M71
On further check, on the latest canary 71.0.3556.0 on Mac OS 10.13.6, hearing 'permission.site wants to' only once which seems to be expected behavior here. Hence adding the verified label.
Labels: OS-Windows
Status: Verified (was: Assigned)

Sign in to add a comment