New issue
Advanced search Search tips

Issue 878191 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Aug 28
Cc:
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Tab dragging - Can't drop the tab window into overview new selector item

Project Member Reported by x...@chromium.org, Aug 28 
Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
(1) In tablet mode, open a browser window with at least 2 tabs
(2) Snap the browser window to left side of the screen
(3) Drag 1 tab out of the browser window to drop on the new selector item in overview in the right side of the screen

What is the expected result?
The tab window will merge into the overview

What happens instead?
The tab window merges back into its source window

It's a regression caused by one of my recent cls: https://chromium-review.googlesource.com/c/chromium/src/+/1180376
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93859a4c486590c64156b57f1fef1c084a084a57

commit 93859a4c486590c64156b57f1fef1c084a084a57
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Aug 28 16:28:28 2018

Tab dragging: the dragged tab window should be able to drop into overview.

When dragging a tab out of a snapped browser window to drop into
overview, it should be able to merge the tab window into the overview.
However, with the recent change to always update the dragged window's
bounds before adding it to overview, it's possible that the dragged
window is merged back into its source window due to its bounds change.
To avoid this, we temmrarily disable the dragged window's ability to
merge into another window when updating the dragged window's bounds and
restore its ability after adding it to overview.

Bug:  878191 
Change-Id: I219517b19f42395ca8a0c095d7313734358e159e
Reviewed-on: https://chromium-review.googlesource.com/1192357
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586733}
[modify] https://crrev.com/93859a4c486590c64156b57f1fef1c084a084a57/ash/wm/overview/window_grid.cc

Comment 2 by x...@chromium.org, Aug 28

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5028a15d842d027969ae63cc3f0de0e816576e08

commit 5028a15d842d027969ae63cc3f0de0e816576e08
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Aug 29 00:48:55 2018

Tab dragging: Only update window bounds if it's in tab-dragging.

When dropping a window into the new selector item, only update its
bounds if it's in tab-dragging process. Other type dragging doesn't
change window bounds during dragging.

Bug:  878191 
Change-Id: I6e9f69035ecaab6a4b423161ab8fe22d14b79b60
Reviewed-on: https://chromium-review.googlesource.com/1195083
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586971}
[modify] https://crrev.com/5028a15d842d027969ae63cc3f0de0e816576e08/ash/wm/overview/window_grid.cc
►

Sign in to add a comment