Desktop PWAs: Origin text animation should fade, not slide |
|||||||
Issue descriptionChrome Version: 70 OS: All that support Desktop PWAs What steps will reproduce the problem? (1) Install a PWA (e.g., https://santatracker.google.com) (2) Open it. What is the expected result? Origin in title bar fades in, then after a few seconds fades out. What happens instead? Origin in title bar slides in from the right, then after a few seconds slides out. This new animation was decided by UX (to be less visually distracting) and agreed by security.
,
Aug 28
,
Aug 28
Screencasts for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1192463
,
Aug 28
👍
,
Sep 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1375b6e13ed007952bc0813d29d8484e24ee51c0 commit 1375b6e13ed007952bc0813d29d8484e24ee51c0 Author: Alan Cutter <alancutter@chromium.org> Date: Sat Sep 01 00:20:19 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588223} [modify] https://crrev.com/1375b6e13ed007952bc0813d29d8484e24ee51c0/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 1
Request to merge this visual change to a security indicator for PWA windows for M70.
,
Sep 2
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
That'll do bugdroid1, that'll do...
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a090fd4f68709486e1b05f7057d2303d31affc6 commit 3a090fd4f68709486e1b05f7057d2303d31affc6 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 04 03:13:48 2018 Update hosted app origin text animation This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e13ed007952bc0813d29d8484e24ee51c0) Reviewed-on: https://chromium-review.googlesource.com/1203511 Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#17} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3a090fd4f68709486e1b05f7057d2303d31affc6/chrome/browser/ui/views/frame/hosted_app_origin_text.cc
,
Sep 6
Tried to Verify the fix on Windows 10, Mac 10.13.6 and Ubuntu 14.40 using Chrome version # 70.0.3538.9 .Attaching screen-cast for reference. Observed that " Origin in title bar fades in and then after a few seconds fades out " NOTE: On Windows 10 and Ubuntu 14.04 its working as expected but Not able to verify this issue on Mac. The marmot title comes on tile bar but it is not fade out stays on title bar. @Alan Cutter : Could you please review the attached screen-cast and help in verifying the fix Thanks...!
,
Sep 7
Oops, this doesn't apply to Mac as we aren't launching on that platform yet. This looks verified to me! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by alancutter@chromium.org
, Aug 28