Error when using CRSBLOG |
|||
Issue description
../../chrome/browser/android/download/download_controller.cc:404:3: error: use of undeclared identifier 'CrSBLogMessage'
CRSBLOG << __FUNCTION__ << ":STAR: item: " << item;
^
../../components/safe_browsing/web_ui/safe_browsing_ui.h:316:17: note: expanded from macro 'CRSBLOG'
#define CRSBLOG CrSBLogMessage().stream()
^
../../chrome/browser/android/download/download_controller.cc:405:3: error: use of undeclared identifier 'CrSBLogMessage'
CRSBLOG << __FUNCTION__ << ":STAR: IsDangerous(): " << item->IsDangerous();
^
../../components/safe_browsing/web_ui/safe_browsing_ui.h:316:17: note: expanded from macro 'CRSBLOG'
#define CRSBLOG CrSBLogMessage().stream()
^
../../chrome/browser/android/download/download_controller.cc:406:3: error: use of undeclared identifier 'CrSBLogMessage'
CRSBLOG << __FUNCTION__ << ":STAR: GetState(): " << item->GetState();
^
../../components/safe_browsing/web_ui/safe_browsing_ui.h:316:17: note: expanded from macro 'CRSBLOG'
#define CRSBLOG CrSBLogMessage().stream()
Please note that using CRSBLOG works in chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
,
Aug 28
I think this is because of namespaces. In the first CL, I forgot to fully qualify CrSBLogMessage, so it only works in namespaces under safe_browsing. I fixed that in the next CL. Does it work if you rebase?
,
Aug 28
Yes, I think that's the case. However, I can't test it since the Clank repo hasn't rolled up to that commit yet. I'll test this again tomorrow after a fetch+rebase. Thanks for taking a look.
,
Sep 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vakh@chromium.org
, Aug 28