New issue
Advanced search Search tips

Issue 878177 link

Starred by 1 user
Status: Fixed
Owner:
jsaul@google.com
Closed: Aug 30
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Chrome can offer local save for local cards under certain conditions

Project Member Reported by jsaul@google.com, Aug 27 
When checking if credit card upload should be offered, if Google Payments declines upload, Chrome falls back to local save.

If the card being considered for upload was already a local card, Chrome can possibly offer local save for the card (again).
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4759a15766f153cba23111c819ac5ad78a6cb682

commit 4759a15766f153cba23111c819ac5ad78a6cb682
Author: Jared Saul <jsaul@google.com>
Date: Thu Aug 30 18:20:19 2018

[Autofill] Avoid offering local save for local cards

If credit card upload is not offered, Chrome can fall back to offering
local save instead.  It shouldn't do this for existing local cards.

Bug:  878177 
Change-Id: I84ba77525864000a34aaa14b51305e854cd23c99
Reviewed-on: https://chromium-review.googlesource.com/1192405
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587665}
[modify] https://crrev.com/4759a15766f153cba23111c819ac5ad78a6cb682/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/4759a15766f153cba23111c819ac5ad78a6cb682/components/autofill/core/browser/credit_card_save_manager_unittest.cc

Comment 2 by jsaul@google.com, Aug 30

Status: Fixed (was: Started)
►

Sign in to add a comment