New issue
Advanced search Search tips

Issue 878162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Folder icon in the first row of the applist clips when long pressed

Project Member Reported by newcomer@chromium.org, Aug 27

Issue description

When press & hold a group in the first row, the pressed state has a trimmed line at the top of circle

https://photos.google.com/share/AF1QipNiGs0jZioS_qk7WTihPS8NFap9yshOACTK_MckLIaW9nq2VHXa1xnY7wBJ_ZGtzQ?key=X0ZfeG1RdU5MVUVlQWRBVkd2LW4weWFXWUV4XzVB
 
Labels: -M-70 M-71
Cc: -weidongg@chromium.org
Owner: weidongg@chromium.org
Status: Started (was: Untriaged)
Can be fixed along with another CL: https://chromium-review.googlesource.com/c/chromium/src/+/1194340
Labels: new-style-launcher
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/332a9576bbfdd0e9776c34900b9ac1ca2d99b9d0

commit 332a9576bbfdd0e9776c34900b9ac1ca2d99b9d0
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed Aug 29 17:56:23 2018

Fix apps grid fade out zone issue

Specs:
https://screenshot.googleplex.com/6gGm7iDdKmB

Bug: 878520, 878162 
Change-Id: I0bd9673232cd0036422ecdb71410151db476290b
Reviewed-on: https://chromium-review.googlesource.com/1194340
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587186}
[modify] https://crrev.com/332a9576bbfdd0e9776c34900b9ac1ca2d99b9d0/ash/app_list/views/apps_container_view.cc
[modify] https://crrev.com/332a9576bbfdd0e9776c34900b9ac1ca2d99b9d0/ash/app_list/views/apps_grid_view.cc

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Reopen this because the issue is only fixed when blur is enabled.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd4706a25591c1f381a7ae22dc0f872e73e5d6e0

commit bd4706a25591c1f381a7ae22dc0f872e73e5d6e0
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Sep 21 00:00:05 2018

Fix the folder icon issue on first row

This is a follow up CL of go/cgcl/1194340 to fix the same issue when
blur is not enabled.

Bug:  878162 
Change-Id: Ia6c3b6942b4304a12bfa3049e0b37252a4deae8f
Reviewed-on: https://chromium-review.googlesource.com/1237403
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593010}
[modify] https://crrev.com/bd4706a25591c1f381a7ae22dc0f872e73e5d6e0/ash/app_list/views/apps_grid_view.cc

Status: Fixed (was: Started)

Sign in to add a comment