New issue
Advanced search Search tips

Issue 878159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Issues while dragging an app icon and showing a menu can freeze applist/shelf

Project Member Reported by newcomer@chromium.org, Aug 27

Issue description

Owner: newcomer@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a972ee73d18c8ea803b105b21c6874b77ab3286

commit 5a972ee73d18c8ea803b105b21c6874b77ab3286
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 30 01:31:18 2018

cros: Prevent showing menu after icon moves.

An app icon can be moved while the callback is being processed.
Detect this and dont show the menu in this case.

Bug:  878159 
Change-Id: I29162449767f865cffc543e13f163e08bfa61cdb
Reviewed-on: https://chromium-review.googlesource.com/1195709
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587378}
[modify] https://crrev.com/5a972ee73d18c8ea803b105b21c6874b77ab3286/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/5a972ee73d18c8ea803b105b21c6874b77ab3286/ash/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/5a972ee73d18c8ea803b105b21c6874b77ab3286/ash/app_list/views/apps_grid_view.h

Status: Fixed (was: Started)

Sign in to add a comment