Issue metadata
Sign in to add a comment
|
mojom::TCPConnectedSocket: There's no way to distinguish a process crash from a graceful close |
||||||||||||||||||||||
Issue descriptionTCPConnectedSocket just closes all pipes when the socket is closed. This is exactly what a network service crash looks like, so the two cases are indistinguishable. We already have a network::mojom::SocketObserver, which sends read/write errors to the consumer. We can fairly easily just invoke the callbacks with net::OK when appropriate. As there are no current consumers of this method, we can change the API without worrying about breaking consumers.
,
Aug 28
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3 commit dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3 Author: Matt Menke <mmenke@chromium.org> Date: Thu Aug 30 07:55:35 2018 Move Pepper TCP and UDP annotations to the same place, update UDP ones. This CL moves the pepper network anntotations to the same file, to more easily keep them in sync, and makes the UDP one match the more complete TCP one. Bug: 878136 Change-Id: I7d607aacedb9298afc3796990c5a713247c32001 Reviewed-on: https://chromium-review.googlesource.com/1194958 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587478} [modify] https://crrev.com/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3/content/browser/renderer_host/pepper/pepper_socket_utils.cc [modify] https://crrev.com/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3/content/browser/renderer_host/pepper/pepper_socket_utils.h [modify] https://crrev.com/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc [modify] https://crrev.com/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc [modify] https://crrev.com/dda4be7a5af0db63dad7cf3e9e042e2f0a0b47a3/tools/traffic_annotation/summary/annotations.xml
,
Aug 30
,
Aug 30
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ed9548b1ba83c34d40c40da53464bbcc237afdf commit 5ed9548b1ba83c34d40c40da53464bbcc237afdf Author: Matt Menke <mmenke@chromium.org> Date: Thu Aug 30 23:33:30 2018 NetworkService: Notify SocketObserver of a graceful close. Previously, there was no way for a consumer to distinguish a graceful socket close from the data pipe being closed for something other than a network error (Network Service crash, NetworkContext shutdown, etc). Bug: 878136 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibf0f1bbe0603a5db2d40945b12d59f243e7e34e9 Reviewed-on: https://chromium-review.googlesource.com/1196964 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587842} [modify] https://crrev.com/5ed9548b1ba83c34d40c40da53464bbcc237afdf/services/network/public/mojom/tcp_socket.mojom [modify] https://crrev.com/5ed9548b1ba83c34d40c40da53464bbcc237afdf/services/network/socket_data_pump.cc [modify] https://crrev.com/5ed9548b1ba83c34d40c40da53464bbcc237afdf/services/network/socket_data_pump_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Aug 27