Improve resource loading hints UMA coverage |
|||||||||||
Issue descriptionBrainstormed with dougarnett, some ideas: 1. Add UMA for count of resources blocked. This would need to be added in Blink. 2. Add UMA for count of resources blocked broken down by the resource's load priority. This would need to be added in Blink, and would be useful for debugging performance improvements. 3. Add UMA to optimization hints service: How many hosts patterns had resource loading hints? How many page patterns had resource loading hints? 4. How many times a hostname match was successful? 5. When a hostname match was successful, how many times the page pattern match was successful?
,
Aug 30
,
Aug 30
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37aed95e54bfd471786923900ba58b44a7869969 commit 37aed95e54bfd471786923900ba58b44a7869969 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Aug 31 04:33:34 2018 Add more UMA for resource loading hints experiment Add more UMA to track the performance and correctness of the resource loading hints experiment. Specifically, this CL records UMA on how many page hints are received via component updater, and how frequently were the resource hints available at the time of page commit. Bug: 878129 Change-Id: I8bc3dd1e6d7c80e4cefc34ebb6119665d5fbee5e Reviewed-on: https://chromium-review.googlesource.com/1197108 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#587944} [modify] https://crrev.com/37aed95e54bfd471786923900ba58b44a7869969/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc [modify] https://crrev.com/37aed95e54bfd471786923900ba58b44a7869969/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc [modify] https://crrev.com/37aed95e54bfd471786923900ba58b44a7869969/components/previews/content/previews_hints.cc [modify] https://crrev.com/37aed95e54bfd471786923900ba58b44a7869969/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/37aed95e54bfd471786923900ba58b44a7869969/tools/metrics/histograms/histograms.xml
,
Aug 31
Merge request for CL in c#4 above.
,
Sep 1
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
Please add appropriate OS labels.
,
Sep 5
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/feb4a0903a59263c0a764e7245ce190bfd900517 commit feb4a0903a59263c0a764e7245ce190bfd900517 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Sep 04 22:01:33 2018 Fix the histogram naming error in resource loading hints The current histogram has not been used yet since the code is behind a field trial that has not been enabled yet. As such, there is no need to deprecate the existing histogram name. Bug: 878129 Change-Id: I90f96d95aa7fd84eadae3173b1580722338489cd Reviewed-on: https://chromium-review.googlesource.com/1204717 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#588666} [modify] https://crrev.com/feb4a0903a59263c0a764e7245ce190bfd900517/components/previews/content/previews_hints.cc [modify] https://crrev.com/feb4a0903a59263c0a764e7245ce190bfd900517/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/feb4a0903a59263c0a764e7245ce190bfd900517/tools/metrics/histograms/histograms.xml
,
Sep 7
Approved for merge into 70, branch 3538.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64940ef93c84719c2624cf1d2bc457e12ce9759f commit 64940ef93c84719c2624cf1d2bc457e12ce9759f Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Sep 07 23:01:26 2018 Add more UMA for resource loading hints experiment Add more UMA to track the performance and correctness of the resource loading hints experiment. Specifically, this CL records UMA on how many page hints are received via component updater, and how frequently were the resource hints available at the time of page commit. Bug: 878129 Change-Id: I8bc3dd1e6d7c80e4cefc34ebb6119665d5fbee5e Reviewed-on: https://chromium-review.googlesource.com/1197108 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587944}(cherry picked from commit 37aed95e54bfd471786923900ba58b44a7869969) Reviewed-on: https://chromium-review.googlesource.com/1214330 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#176} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/64940ef93c84719c2624cf1d2bc457e12ce9759f/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc [modify] https://crrev.com/64940ef93c84719c2624cf1d2bc457e12ce9759f/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc [modify] https://crrev.com/64940ef93c84719c2624cf1d2bc457e12ce9759f/components/previews/content/previews_hints.cc [modify] https://crrev.com/64940ef93c84719c2624cf1d2bc457e12ce9759f/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/64940ef93c84719c2624cf1d2bc457e12ce9759f/tools/metrics/histograms/histograms.xml
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/896e568716b3f413e38e45b2cc0e18728e50d7c7 commit 896e568716b3f413e38e45b2cc0e18728e50d7c7 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Sep 07 23:04:04 2018 Fix the histogram naming error in resource loading hints The current histogram has not been used yet since the code is behind a field trial that has not been enabled yet. As such, there is no need to deprecate the existing histogram name. Bug: 878129 Change-Id: I90f96d95aa7fd84eadae3173b1580722338489cd Reviewed-on: https://chromium-review.googlesource.com/1204717 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588666}(cherry picked from commit feb4a0903a59263c0a764e7245ce190bfd900517) Reviewed-on: https://chromium-review.googlesource.com/1214079 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#177} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/896e568716b3f413e38e45b2cc0e18728e50d7c7/components/previews/content/previews_hints.cc [modify] https://crrev.com/896e568716b3f413e38e45b2cc0e18728e50d7c7/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/896e568716b3f413e38e45b2cc0e18728e50d7c7/tools/metrics/histograms/histograms.xml
,
Sep 7
,
Sep 7
,
Sep 7
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 29