New issue
Advanced search Search tips

Issue 878122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 812040



Sign in to add a comment

Offline Demo Mode enrollment fails in GetServerBackedStateKeys

Project Member Reported by michae...@chromium.org, Aug 27

Issue description

Offline Demo Mode enrollment times out waiting for GetServerBackedStateKeys and fails with NO_STATE_KEYS, if the device has been offline since boot.

This might only repro if FRE is on, which is true if chrome is build with `is_official_build = true`.

The GetServerBackedStateKeys dbus timeout is expected when there hasn't been network connectivity since boot:
https://cs.chromium.org/chromium/src/chromeos/dbus/session_manager_client.cc?type=cs&q=TIMEOUT_INFINITE+session_manager_client&sq=package:chromium&g=0&l=389

But the keys are required for FRE:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc?type=cs&sq=package:chromium&g=0&l=380

Connecting the device to a network will allow the retry attempt to succeed, but that partly defeats the purpose of an offline mode.

Relevant logs:

[3257:3257:0827/140338.870793:VERBOSE1:demo_setup_controller.cc(155)] Starting demo mode enrollment offline
[3257:3257:0827/140721.340531:ERROR:object_proxy.cc(615)] Failed to call method: org.chromium.SessionManagerInterface.GetServerBackedStateKeys: object_path= /org/chromium/SessionManager: org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus)
[3257:3257:0827/140721.340604:WARNING:server_backed_state_keys_broker.cc(75)] Failed to obtain server-backed state keys.
[3257:3257:0827/140721.340656:WARNING:enrollment_handler_chromeos.cc(813)] Enrollment failed: 1, client: 0, validation: 0, store: 0, lock: 0
[3257:3257:0827/140721.340731:ERROR:demo_setup_controller.cc(347)] EnrollmentError: status: 1 client_status: 0 store_status: 0 validation_status: 0 lock_status: 0 fatal=0

 
Owner: agawronska@chromium.org
Status: Assigned (was: Available)
Blocking: 812040
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9915b168217a54f5c4f32de89e1a9b58d957a28b

commit 9915b168217a54f5c4f32de89e1a9b58d957a28b
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Sep 13 19:13:34 2018

Skip state key request in offline demo setup.

Bug:  878122 
Test: Run DemoSetupFRETest and manually.
Change-Id: Ic171d8f1f9609f62ae443dd69d2697f730f3cd75
Reviewed-on: https://chromium-review.googlesource.com/1198362
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591103}
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chrome/browser/chromeos/policy/enrollment_config.h
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chromeos/system/statistics_provider.cc
[modify] https://crrev.com/9915b168217a54f5c4f32de89e1a9b58d957a28b/chromeos/system/statistics_provider.h

Status: Fixed (was: Started)

Sign in to add a comment