New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878083 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Hide controls after 2.5s if initially triggered by touch event.

Project Member Reported by apaci...@chromium.org, Aug 27

Issue description

Currently, if the user uses a touch screen to show the controls, they don't leave unless the user presses outside of the window.

After 2.5s of no interaction, hide the controls if they were initially shown from interacting with the window using touch.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcecf03e2a0f4c0105dbf877786c16b95fb73a1e

commit fcecf03e2a0f4c0105dbf877786c16b95fb73a1e
Author: Jennifer Apacible <apacible@chromium.org>
Date: Wed Aug 29 00:36:48 2018

[Picture in Picture] Auto-hide controls after 2.5s after user tap.

Currently, gesture interactions (tap) shows the controls, but they only
disappear if the user taps outside of the window to blur. There is no
other way of "hiding" the controls similar to using a mouse to no
longer hover over the window.

This change hides the controls automatically after 2.5 seconds. Every
time the user taps on the window, the 2.5s is reset. If there is some
other user gesture (e.g. mouse hover), the timer is stopped.

Bug:  878083 
Change-Id: I9d3a4b28b92e495960ac98eb9a9fcf9a1103bfb6
Reviewed-on: https://chromium-review.googlesource.com/1192358
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586965}
[modify] https://crrev.com/fcecf03e2a0f4c0105dbf877786c16b95fb73a1e/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/fcecf03e2a0f4c0105dbf877786c16b95fb73a1e/chrome/browser/ui/views/overlay/overlay_window_views.h

Status: Fixed (was: Assigned)
Cc: vamshi.kommuri@chromium.org
Labels: Needs-Feedback
@Jennifer Apacible: As we are not very clear about the test steps, could you please help us in providing the test steps required along with any test file(...if applicable) and help us in verifying the fix.

Thanks!

Sign in to add a comment