IDL attribute getters and setters should have name property set |
|||
Issue descriptionChrome Version: (copy from chrome://version) 70.0.3534.0 (Official Build) canary (64-bit) OS: (e.g. Win10, MacOS 10.12, etc...) macOS 10.13.6 What steps will reproduce the problem? (1) Object.getOwnPropertyDescriptor(URL.prototype, "hash").get.name (2) Object.getOwnPropertyDescriptor(URL.prototype, "hash").set.name What is the expected result? (1) "get hash" is shown (2) "set hash" is shown This is the case per Web IDL spec (1) https://heycam.github.io/webidl/#dfn-attribute-getter step 4 (2) https://heycam.github.io/webidl/#dfn-attribute-setter step 6 What happens instead? Both are the empty string. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44f5ffe622f37f67761e1d2ad387cb53f183be9b commit 44f5ffe622f37f67761e1d2ad387cb53f183be9b Author: Timothy Gu <timothygu@chromium.org> Date: Tue Sep 04 16:40:45 2018 bindings: Set function name for attribute accessors This aligns the behavior with the current Web IDL specification as well as Firefox and Safari. Bug: 878074 Change-Id: Ia862c1d0d8319fb78726817b69f9151e5fb500fd Reviewed-on: https://chromium-review.googlesource.com/1191727 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#588544} [modify] https://crrev.com/44f5ffe622f37f67761e1d2ad387cb53f183be9b/third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js [modify] https://crrev.com/44f5ffe622f37f67761e1d2ad387cb53f183be9b/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt [modify] https://crrev.com/44f5ffe622f37f67761e1d2ad387cb53f183be9b/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt [modify] https://crrev.com/44f5ffe622f37f67761e1d2ad387cb53f183be9b/third_party/blink/renderer/bindings/core/v8/v8_dom_configuration.cc
,
Sep 4
,
Sep 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by timothygu@chromium.org
, Aug 27