New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878039 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 878040
issue 878041



Sign in to add a comment

Re-enable the ability enable shelf auto-hide in tablet mode.

Project Member Reported by newcomer@chromium.org, Aug 27

Issue description

1. Return the context menu option of "Auto-hide" for Shelf in tablet mode
2.  Respect auto-hide bit in tablet mode if it is set in clamshell mode.


 
Blocking: 878040 878041
Labels: M-70 Pri-1
Cc: kaznacheev@chromium.org
Owner: kaznacheev@chromium.org
Cc: newcomer@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0632cd6ccf8fd833f373263d2fc26bca19262159

commit 0632cd6ccf8fd833f373263d2fc26bca19262159
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Aug 30 21:37:15 2018

Re-enable shelf auto-hide in tablet mode

- show auto-hide related menu option in tablet mode
- respect auto-hide bit in tablet mode if it is set in clamshell mode
- update test accordingly

  ash_unittests --gtest_filter=Shelf*

Bug:  878039 
Test: manual, ash_unittests --gtest_filter=TabletModeWindowManagerTest*,
Change-Id: I8a8688e794e243e4b2da026803dff9e136f3c1f1
Reviewed-on: https://chromium-review.googlesource.com/1196142
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587783}
[modify] https://crrev.com/0632cd6ccf8fd833f373263d2fc26bca19262159/ash/shelf/shelf_context_menu_model.cc
[modify] https://crrev.com/0632cd6ccf8fd833f373263d2fc26bca19262159/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/0632cd6ccf8fd833f373263d2fc26bca19262159/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/0632cd6ccf8fd833f373263d2fc26bca19262159/ash/shelf/shelf_controller_unittest.cc
[modify] https://crrev.com/0632cd6ccf8fd833f373263d2fc26bca19262159/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc

Status: Fixed (was: Started)
Cc: manucornet@chromium.org mccanny@chromium.org
 Issue 878041  has been merged into this issue.

Sign in to add a comment