New issue
Advanced search Search tips

Issue 878011 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 878010

Blocking:
issue 877684



Sign in to add a comment

update SkiaRenderer sync for gpu/vulkan barriers

Project Member Reported by rjkroege@chromium.org, Aug 27

Issue description

modify SkiaRenderer to correctly use semaphores and fences for synchronization on Vulkan.
 
Blocking: 877684
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d5585786e93f3fe5bf6cb81934b58799c59e0d

commit 99d5585786e93f3fe5bf6cb81934b58799c59e0d
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Sep 10 15:16:14 2018

Set swap chain image layouts correctly for rastering and presenting.

This change also fixes the synchronization problem.

Bug:  878011 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I15f73c32b76fdf9456e26e811d36b9d8dcfe35d6
Reviewed-on: https://chromium-review.googlesource.com/1195661
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589916}
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/gpu/vulkan/demo/vulkan_demo.cc
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/gpu/vulkan/demo/vulkan_demo.h
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/gpu/vulkan/vulkan_swap_chain.cc
[modify] https://crrev.com/99d5585786e93f3fe5bf6cb81934b58799c59e0d/gpu/vulkan/vulkan_swap_chain.h

Status: Fixed (was: Started)

Sign in to add a comment