Handle missing/expired cache in packages.py checksum code |
||||||
Issue descriptionMemqual fails with "Unhandled ValueError: need more than 1 value to unpack". The image cache expires during memqual's run and when the package manager code tries to fetch artifacts from devserver, it instead gets a cherrypy 404 page. This HTML page is saved directly in packages.checksum, which breaks the checksum management code.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6da5d6b30a008319ec5dfdeca3c77c90833cb502 commit 6da5d6b30a008319ec5dfdeca3c77c90833cb502 Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Oct 02 12:19:28 2018 [autotest] Make sure autotest is staged before package install Fixing an issue where at times the package manager would attempt to install autotest after devserver's cache had expired. The install would fail silently and would blow up when the packages.checksum was a devserver 404 page instead of the expected checksum file format. Simply use the cros_host.verify_job_repo_url function to verify the devserver is reachable, and make the devserver stage the autotest artifacts if needed. BUG= chromium:878008 , b:109894838 TEST=Run hardware_memoryqual on local moblab Change-Id: I147a50b14c6f1b4cac8b98049c8977f16542d012 Reviewed-on: https://chromium-review.googlesource.com/1246470 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/6da5d6b30a008319ec5dfdeca3c77c90833cb502/server/autotest.py [modify] https://crrev.com/6da5d6b30a008319ec5dfdeca3c77c90833cb502/server/autotest_unittest.py
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/579c72a7659f5bd7688d40a3656f54dd9dca4381 commit 579c72a7659f5bd7688d40a3656f54dd9dca4381 Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Oct 02 12:19:28 2018 [autotest] curl should fail on non 200 from devserver curl fails silently, and downloads an html 404 page instead of the expected content. Update curl to return non-zero status on non 200 status code BUG= chromium:878008 , b:109894838 TEST=Run hardware_memoryqual on local moblab Change-Id: I2baae6f713f7323f97dae99bb0550fdcc98f53d5 Reviewed-on: https://chromium-review.googlesource.com/1249614 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/579c72a7659f5bd7688d40a3656f54dd9dca4381/client/common_lib/packages.py
,
Oct 18
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by haddowk@chromium.org
, Aug 28