New issue
Advanced search Search tips

Issue 878004 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SendToUma should have a min of > 0

Project Member Reported by maybelle@chromium.org, Aug 27

Issue description

In update engine, there are many instances where we call SendToUma with a min of 0, e.g.: https://cs.corp.google.com/aosp-master/system/update_engine/metrics_reporter_omaha.cc?rcl=d944faad2e460af36df59e95c5371ca6b87309d3&l=151

According to isherman, this is incorrect, and the min should never be 0:
https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/1179230/7/metrics_reporter_omaha.cc#634

Chromium eventually enforces this by setting the 0's to 1's (https://cs.chromium.org/chromium/src/base/metrics/histogram.cc?l=418-426&rcl=4e6b50ac1cc073c2bd33d56deeb26ce27881ce66), but it's better in the first place to just have the min as 1.
 

Sign in to add a comment