[PIP] Hide controls while resizing. |
|||
Issue descriptionCurrently, while the window is resizing, the controls are shown. There is slight jank when the controls are trying to scale to the new window size. Since the user can't interact with the controls while resizing (and may want to gauge how large/small they want the video based on its contents), hide the controls.
,
Aug 28
,
Aug 30
Tested the issue on chrome reported version# 70.0.3534.4 using Ubuntu 14.04 with steps mentioned below: 1) Launched chrome reported version and enabled PIP flag from Chrome://flags 2) Opened the URL: https://japacible.github.io/sandbox/index.html and resized the video, didn't observed any janky in the controls @Jennifer Apacible: Please find the attached screencast for your reference and let us know if we missed anything in reproducing the issue and help us in verifying the fix. Thanks!
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8a51d5a8b6ff221ac49e18c1a224a9ef4810d0 commit bd8a51d5a8b6ff221ac49e18c1a224a9ef4810d0 Author: Jennifer Apacible <apacible@chromium.org> Date: Thu Aug 30 23:16:38 2018 [Picture in Picture] Hide controls on all platforms while resizing/moving. This change hides the controls on the Picture-in-Picture window on all platforms while moving the window or when the size updates. Previously, this was handled on Windows. The controls cannot be interacted with during the resize and dragging actions. They also slightly obscure the video, especially the play/pause icon. Removing the controls will allow the user to view the final video size and position. Bug: 877987 Change-Id: I788d8cb5690e3c587f93b21ad7eb7d0a2c69ecef Reviewed-on: https://chromium-review.googlesource.com/1197722 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#587832} [modify] https://crrev.com/bd8a51d5a8b6ff221ac49e18c1a224a9ef4810d0/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/bd8a51d5a8b6ff221ac49e18c1a224a9ef4810d0/chrome/browser/ui/views/overlay/overlay_window_views.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 28