Flake Detection: Merge similar webkit layout tests bugs |
||
Issue descriptionIn crbug.com/877104 , there are quite a few flaky webkit layout tests that have different bugs filed for them, but actually, they should be merged into the same one. For example: external/wpt/editing/run/delete.html?1-1000 external/wpt/editing/run/delete.html?1001-2000 external/wpt/editing/run/delete.html?3001-4000 external/wpt/editing/run/delete.html?4001-5000 external/wpt/editing/run/delete.html?5001-6000 external/wpt/editing/run/delete.html?6001-last external/wpt/editing/run/forward_delete.html?1-1000 external/wpt/editing/run/forward_delete.html?1001-2000 external/wpt/editing/run/forward_delete.html?2001-3000 external/wpt/editing/run/forward_delete.html?3001-4000 external/wpt/editing/run/forward_delete.html?4001-5000 external/wpt/editing/run/forward_delete.html?5001-6000 external/wpt/editing/run/forward_delete.html?6001-last
,
Aug 27
It would be a pretty good assumption that tests that differ only by the query parameters are sufficiently similar that if they're all flaky, the cause is the same. This won't always be the case, but creating separate bugs will be more annoying than useful, I suspect.
,
Aug 27
Thanks for the feedback foolip@! I'm working on a new Flake Detection to replace the Chromium-try-flakes, and it will be online soon, I will make sure to merge similar webkit layout tests bugs in the new Flake Detection.
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb commit b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Aug 29 19:16:42 2018 [FindIt] Merge webkit_layout_tests differ by queries This CL merged webkit_layout_tests bugs that only differ by queries. For example, external/wpt/editing/run/delete.html?1-1000 external/wpt/editing/run/delete.html?1001-2000 Bug: 877974 Change-Id: I3d5d9fe69da07175c61f98240223315d3a24c7b4 Reviewed-on: https://chromium-review.googlesource.com/1195724 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#17282} [modify] https://crrev.com/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb/appengine/findit/model/flake/detection/flake.py [modify] https://crrev.com/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb/appengine/findit/libs/test_results/gtest_test_results.py [modify] https://crrev.com/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb/appengine/findit/model/flake/detection/test/flake_test.py [add] https://crrev.com/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb/appengine/findit/libs/test/test_name_util_test.py [rename] https://crrev.com/b3af1592edca7b3cd2a12e3c39a8cd65fe0d4edb/appengine/findit/libs/test_name_util.py [delete] https://crrev.com/77b987ac614d82d232e98bd680b927af888c1559/appengine/findit/libs/test/gtest_name_util_test.py
,
Aug 29
|
||
►
Sign in to add a comment |
||
Comment 1 by liaoyuke@chromium.org
, Aug 27