New issue
Advanced search Search tips

Issue 877971 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 734150



Sign in to add a comment

Tabs in tab grid sometimes lose their titles

Project Member Reported by marq@chromium.org, Aug 27

Issue description

Circumstances unknown, but occasionally a non-NTP tab in the grid doesn't show a title. After the tab is reloaded, (presumably: by opening the tab and then re-entering the grid), the title is restored.

Reported in 69.0.3497.41 beta on an iPhone X.
 
Could potentially be related to dynamic type sizes, or other a11y features.
Components: UI>Browser>Mobile>TabSwitcher
This can be reproduced with #slim-navigation-manager enabled.

1. Launch Google Chrome
2. Enable SlimNavigation Manager.
3. Open few websites and make sure you see the tab title and snapshot displayed correctly.
4. Background the app, Force quit and Relaunch
5. Enter tab switcher.

Observe that tab title is missing for tabs.

Based on the screenshot from the email thread I can see the experiment d14aee9b-807c99ad is related to SlimNavigationManager.
So far not able to reproduce without slim-navigation-manager but will keep an eye to see if this reproduces without need of slim-navigation-manager.
Labels: -M-70 M-71
Labels: Proj-WKBackForwardList
Labels: ReleaseBlock-Stable
Hi Marq - any update here? Is this repro'ed without slim-nav?
Labels: -ReleaseBlock-Stable -M-71 Proj-WKBackForwardListBlockers
Owner: danyao@chromium.org
I found one use case in test that may be related to this issue. GetTitle() is called on a placeholder item that doesn't yet have the navigation item associated. This situation can result in empty title.

This is happening in egtest:
./out/Debug-iphonesimulator/iossim -t NavigationTestCase/testRestoreHistoryToNTPAndNavigateForward -c --enable-features=SlimNavigationManager ./out/Debug-iphonesimulator/ios_chrome_web_egtests.app ./out/Debug-iphonesimulator/ios_chrome_web_egtests_module.xctest

[1102/180209.119697:FATAL:browser_about_rewriter.cc(35)] Check failed: (*url == url::kAboutBlankURL) || !url->SchemeIs(url::kAboutScheme). 
0   ios_chrome_web_egtests              0x0000000105bd5a5d base::debug::StackTrace::StackTrace(unsigned long) + 157
1   ios_chrome_web_egtests              0x0000000105bd5a9d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_web_egtests              0x00000001058a4a0a base::debug::StackTrace::StackTrace() + 26
3   ios_chrome_web_egtests              0x00000001058eaded logging::LogMessage::~LogMessage() + 461
4   ios_chrome_web_egtests              0x00000001058e8a95 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_web_egtests              0x0000000102f11666 WillHandleWebBrowserAboutURL(GURL*, web::BrowserState*) + 646
6   ios_chrome_web_egtests              0x0000000103e65e84 web::BrowserURLRewriter::RewriteURLWithWriters(GURL*, web::BrowserState*, std::__1::vector<bool (*)(GURL*, web::BrowserState*), std::__1::allocator<bool (*)(GURL*, web::BrowserState*)> > const&) + 420
7   ios_chrome_web_egtests              0x0000000103e66a69 web::BrowserURLRewriterImpl::RewriteURLIfNecessary(GURL*, web::BrowserState*) + 41
8   ios_chrome_web_egtests              0x0000000103e95e58 web::NavigationManagerImpl::CreateNavigationItemWithRewriters(GURL const&, web::Referrer const&, ui::PageTransition, web::NavigationInitiationType, GURL const&, std::__1::vector<bool (*)(GURL*, web::BrowserState*), std::__1::allocator<bool (*)(GURL*, web::BrowserState*)> > const*) const + 376
9   ios_chrome_web_egtests              0x0000000103fc54d5 web::WKBasedNavigationManagerImpl::WKWebViewCache::GetNavigationItemImplAtIndex(unsigned long, bool) const + 997
10  ios_chrome_web_egtests              0x0000000103fc971b web::WKBasedNavigationManagerImpl::GetNavigationItemImplAtIndex(unsigned long) const + 171
11  ios_chrome_web_egtests              0x0000000103fc97d4 web::WKBasedNavigationManagerImpl::GetLastCommittedItemImpl() const + 164
12  ios_chrome_web_egtests              0x0000000103e95cd9 web::NavigationManagerImpl::GetLastCommittedItem() const + 25
13  ios_chrome_web_egtests              0x000000010405c9ae web::WebStateImpl::GetTitle() const + 302
14  ios_chrome_web_egtests              0x00000001057aa21f (anonymous namespace)::CreateItem(web::WebState*) + 303
15  ios_chrome_web_egtests              0x00000001057aac4e -[TabGridMediator snapshotCache:didUpdateSnapshotForIdentifier:] + 334
16  CoreFoundation                      0x000000011253611c __invoking___ + 140
17  CoreFoundation                      0x00000001125335b5 -[NSInvocation invoke] + 325
18  CoreFoundation                      0x0000000112533a06 -[NSInvocation invokeWithTarget:] + 54
19  ios_chrome_web_egtests              0x00000001058d3d59 -[CRBProtocolObservers forwardInvocation:] + 521
20  CoreFoundation                      0x0000000112533d14 ___forwarding___ + 772
21  CoreFoundation                      0x0000000112535e88 _CF_forwarding_prep_0 + 120
22  ios_chrome_web_egtests              0x00000001045f4b63 -[SnapshotCache removeImageWithSessionID:] + 675
23  ios_chrome_web_egtests              0x00000001046038a9 -[SnapshotGenerator removeSnapshot] + 89
24  ios_chrome_web_egtests              0x0000000104608663 SnapshotTabHelper::RemoveSnapshot() + 259
25  ios_chrome_web_egtests              0x0000000104609073 SnapshotTabHelper::DidStartLoading(web::WebState*) + 51
26  ios_chrome_web_egtests              0x000000010405abb1 web::WebStateImpl::SetIsLoading(bool) + 305
27  ios_chrome_web_egtests              0x0000000103f3a626 -[CRWWebController registerLoadRequestForURL:referrer:transition:sameDocumentNavigation:hasUserGesture:] + 2294
28  ios_chrome_web_egtests              0x0000000103f3ecc6 -[CRWWebController didLoadNativeContentForNavigationItem:] + 246
29  ios_chrome_web_egtests              0x0000000103f6c1ff -[CRWWebController webView:didFinishNavigation:] + 4767

Cc: justincohen@chromium.org
Labels: -Proj-WKBackForwardListBlockers Proj-WKBackForwardListBlocker
Cc: danyao@chromium.org
Labels: Needs-Feedback
Owner: srikanthg@chromium.org
I haven't seen this problem lately. srikanthg@ - would you help to retest on canary? Thanks!
Blockedon: 734150
Blocking: 734150
Blockedon: -734150
Srikanth, could you please check if this bug is reproducible on Canary.
Labels: -Needs-Feedback
Status: WontFix (was: Assigned)
Sorry for the delay. I tried to reproduce on M72.0.3617.0 canary with SlimNav enabled and the issue is not reproducible.

Sign in to add a comment